Create a directory for --out-dir if it does not already exist #47854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if `--out-dir` is set to a non-existent directory, the compiler will throw unfriendly messages like `error: could not write output to subdir/example.crate.allocator.rcgu.o: No such file or directory`, which, while not completely unreadable, isn’t very user-friendly either. This change creates the directory automatically if it does not yet exist.
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
T-compiler
|
@pnkfelix ping from triage! This PR needs a review. |
|
@bors r+ rollup |
|
📌 Commit 79d85da has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 8, 2018
Create a directory for --out-dir if it does not already exist Currently if `--out-dir` is set to a non-existent directory, the compiler will throw unfriendly messages like `error: could not write output to subdir/example.crate.allocator.rcgu.o: No such file or directory`, which, while not completely unreadable, isn’t very user-friendly either. This change creates the directory automatically if it does not yet exist.
bors
added a commit
that referenced
this pull request
Feb 8, 2018
bors
added a commit
that referenced
this pull request
Feb 9, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 9, 2018
Create a directory for --out-dir if it does not already exist Currently if `--out-dir` is set to a non-existent directory, the compiler will throw unfriendly messages like `error: could not write output to subdir/example.crate.allocator.rcgu.o: No such file or directory`, which, while not completely unreadable, isn’t very user-friendly either. This change creates the directory automatically if it does not yet exist.
bors
added a commit
that referenced
this pull request
Feb 9, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 10, 2018
Create a directory for --out-dir if it does not already exist Currently if `--out-dir` is set to a non-existent directory, the compiler will throw unfriendly messages like `error: could not write output to subdir/example.crate.allocator.rcgu.o: No such file or directory`, which, while not completely unreadable, isn’t very user-friendly either. This change creates the directory automatically if it does not yet exist.
bors
added a commit
that referenced
this pull request
Feb 10, 2018
bors
added a commit
that referenced
this pull request
Feb 10, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
--out-diris set to a non-existent directory, the compiler will throw unfriendly messages likeerror: could not write output to subdir/example.crate.allocator.rcgu.o: No such file or directory, which, while not completely unreadable, isn’t very user-friendly either. This change creates the directory automatically if it does not yet exist.