Skip to content

Fix error-format to properly send JSON to stdout #48558

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

Fix error-format to properly send JSON to stdout #48558

merged 1 commit into from
Feb 28, 2018

Conversation

Mark-Simulacrum
Copy link
Member

Since we take Cargo's JSON messages as well we need to specifically send
rustc's messages out so we don't hide them.

r? @Manishearth

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 26, 2018
Closed
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 26, 2018

📌 Commit 9c80019 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@kennytm kennytm mentioned this pull request Feb 27, 2018
Closed
@alexcrichton
Copy link
Member

@bors: rollup

kennytm added a commit to kennytm/rust that referenced this pull request Feb 27, 2018
@kennytm
Rollup merge of rust-lang#48558 - Mark-Simulacrum:error-format, r=Man…
5805538 
…ishearth

Fix error-format to properly send JSON to stdout

Since we take Cargo's JSON messages as well we need to specifically send
rustc's messages out so we don't hide them.

r? @Manishearth
kennytm added a commit to kennytm/rust that referenced this pull request Feb 28, 2018
@kennytm
Rollup merge of rust-lang#48558 - Mark-Simulacrum:error-format, r=Man…
4b4cd47 
…ishearth

Fix error-format to properly send JSON to stdout

Since we take Cargo's JSON messages as well we need to specifically send
rustc's messages out so we don't hide them.

r? @Manishearth
@kennytm kennytm mentioned this pull request Feb 28, 2018
Merged
bors added a commit that referenced this pull request Feb 28, 2018
@bors
Auto merge of #48608 - kennytm:rollup, r=kennytm
0ff9872 
Rollup of 15 pull requests

- Successful merges: #48266, #48321, #48365, #48381, #48450, #48473, #48479, #48484, #48488, #48497, #48541, #48548, #48558, #48560, #48565
- Failed merges:
@bors bors merged commit 9c80019 into rust-lang:master Feb 28, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the error-format branch June 8, 2019 13:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @Manishearth @bors @alexcrichton @rust-highfive