Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document format_args! / Arguments<'a> behavior wrt. Display and Debug #49229

Merged
merged 3 commits into from
Mar 24, 2018

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 21, 2018

This is a follow up PR to #49067 , this documents the behavior of format_args! (i.e: Argument<'a>) wrt. Display and Debug.

r? @steveklabnik

@Centril Centril added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Mar 21, 2018
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2018
@Centril Centril added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 21, 2018
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me, thanks! travis is failing due to the trailing whitespace though. r=me once it's green

///
/// struct Arm<'a, L: 'a, R: 'a>(&'a (L, R));
/// struct Table<'a, K: 'a, V: 'a>(&'a [(K, V)], V);
///
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've got trailing whitespace here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How embarrassing; should have run tidy ^,- I'll fix this sometime tonight =)

@Centril
Copy link
Contributor Author

Centril commented Mar 23, 2018

r=@steveklabnik

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 24, 2018

📌 Commit 613fb8b has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
…ug, r=steveklabnik

Document format_args! / Arguments<'a> behavior wrt. Display and Debug

This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`.
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
…ug, r=steveklabnik

Document format_args! / Arguments<'a> behavior wrt. Display and Debug

This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`.

r? @steveklabnik
bors added a commit that referenced this pull request Mar 24, 2018
@bors bors merged commit 613fb8b into rust-lang:master Mar 24, 2018
@Centril Centril deleted the doc/format_args_display_debug branch March 24, 2018 21:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants