Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix IE11 search #49312

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Fix IE11 search #49312

merged 1 commit into from
Mar 24, 2018

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 23, 2018 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2018
@QuietMisdreavus
Copy link
Member

Confirmed search works in IE11 with this change. Tidy passed, so I'll go ahead and r+.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 23, 2018

📌 Commit 90588a9 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge of rust-lang#49312 - GuillaumeGomez:fix-ie11-search, r=Q…
8cb9b83 
…uietMisdreavus

Fix IE11 search

Fixes rust-lang#49263.

r? @QuietMisdreavus

I got this code from: https://stackoverflow.com/a/30867255/7879548
@alexcrichton alexcrichton mentioned this pull request Mar 23, 2018
Closed
@kennytm kennytm mentioned this pull request Mar 24, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49312 - GuillaumeGomez:fix-ie11-search, r=Q…
5082bde 
…uietMisdreavus

Fix IE11 search

Fixes rust-lang#49263.

r? @QuietMisdreavus

I got this code from: https://stackoverflow.com/a/30867255/7879548
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49312 - GuillaumeGomez:fix-ie11-search, r=Q…
2580edf 
…uietMisdreavus

Fix IE11 search

Fixes rust-lang#49263.

r? @QuietMisdreavus

I got this code from: https://stackoverflow.com/a/30867255/7879548
@kennytm kennytm mentioned this pull request Mar 24, 2018
Merged
bors added a commit that referenced this pull request Mar 24, 2018
@bors
Auto merge of #49337 - kennytm:rollup, r=kennytm
f5631d9 
Rollup of 21 pull requests

- Successful merges: #49046, #49076, #49089, #49120, #49121, #49122, #49162, #49193, #49194, #49203, #49229, #49235, #49254, #49268, #49273, #49274, #49290, #49312, #49314, #49318, #49299
@bors bors merged commit 90588a9 into rust-lang:master Mar 24, 2018
@GuillaumeGomez GuillaumeGomez deleted the fix-ie11-search branch March 25, 2018 19:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @rust-highfive