Skip to content

Remove statics field from CodegenCx #53274

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 11, 2018

It doesnt seem to be used anywhere.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2018
@nagisa
Copy link
Member

nagisa commented Aug 11, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 11, 2018

📌 Commit 44af068 has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Aug 11, 2018

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 12, 2018
Remove statics field from CodegenCx

It doesnt seem to be used anywhere.
@michaelwoerister
Copy link
Member

Nice find!

kennytm added a commit to kennytm/rust that referenced this pull request Aug 13, 2018
Remove statics field from CodegenCx

It doesnt seem to be used anywhere.
kennytm added a commit to kennytm/rust that referenced this pull request Aug 14, 2018
Remove statics field from CodegenCx

It doesnt seem to be used anywhere.
bors added a commit that referenced this pull request Aug 14, 2018
Rollup of 11 pull requests

Successful merges:

 - #53112 (pretty print BTreeSet)
 - #53208 (Don't panic on std::env::vars() when env is null.)
 - #53226 (driver: set the syntax edition in phase 1)
 - #53229 (Make sure rlimit is only ever increased)
 - #53233 (targets: aarch64: Add bare-metal aarch64 target)
 - #53239 (rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5.)
 - #53246 (A few cleanups)
 - #53257 (Idiomatic improvements to IP method)
 - #53274 (Remove statics field from CodegenCx)
 - #53290 (Make LLVM emit assembly comments with -Z asm-comments)
 - #53317 (Mark prior failure to avoid ICE)
@bors bors merged commit 44af068 into rust-lang:master Aug 14, 2018
@bjorn3 bjorn3 deleted the remove_statics_field branch August 14, 2018 19:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants