-
Notifications
You must be signed in to change notification settings - Fork 13.4k
make asm diagnostic instruction optional #55193
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
`DiagnosticInfoInlineAsm::getInstruction` may return a null pointer, so the instruction shouldn't be blindly unwrapped. Fixes rust-lang#23458.
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit 8e50140 has been approved by |
https://ci.appveyor.com/project/rust-lang/rust/builds/19663782/job/s4v19q20t4uttnsr
@bors r- |
Rollup of 5 pull requests Successful merges: - #55156 (Fixed: Multiple errors on single typo in match pattern) - #55189 (update books for the next release) - #55193 (make asm diagnostic instruction optional) - #55203 (Write an initial version of the `program_clauses` callback) - #55213 (ignore target folders) Failed merges: r? @ghost
@bors r+ rollup |
📌 Commit 8e50140 has been approved by |
@bors r- |
I see @Manishearth's comment now... |
Any idea what's up with that failure @euclio ? |
Not yet, I've been having trouble building Rust on my Windows machine. Hoping to get some more info this week. |
Would it be possible for you to produce a backtrace for the assertion? Assembly printing goes through different code-paths for GCC-style and MS-style assembly, so this might be a platform difference. However, as LLVM assertions are default disabled nowadays, it might just be that the assertion occurs on both Linux and Windows before the diagnostic is emitted. |
DiagnosticInfoInlineAsm::getInstruction
may return a null pointer, sothe instruction shouldn't be blindly unwrapped.
Fixes #23458.
Fixes #55216.