Clean up and fix a bug in query plumbing #57480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Looks good. What's the bug being fixed? |
Zoxc
commented
Jan 14, 2019
| TryGetJob::JobCompleted(_) => return, | ||
| TryGetJob::JobCompleted(result) => { | ||
| if let Err(e) = result { | ||
| self.report_cycle(e).emit(); |
There was a problem hiding this comment.
The bug fix is reporting this error.
|
@bors r+ |
|
📌 Commit 60d1db6 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
Clean up and fix a bug in query plumbing r? @michaelwoerister
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
Clean up and fix a bug in query plumbing r? @michaelwoerister
bors
added a commit
that referenced
this pull request
Jan 14, 2019
Rollup of 8 pull requests Successful merges: - #57043 (Fix poor worst case performance of set intersection) - #57480 (Clean up and fix a bug in query plumbing) - #57481 (provide suggestion for invalid boolean cast) - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser) - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`) - #57572 (Unaccept `extern_in_paths`) - #57585 (Recover from item trailing semicolon) - #57589 (Add a debug_assert to Vec::set_len) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @michaelwoerister