Skip to content

Add a debug_assert to Vec::set_len #57589

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

scottmcm
Copy link
Member

Following the precedent of #52972, which found llogiq/bytecount#42.

(This may well make a test fail; let's see what Travis says.)

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019
@scottmcm scottmcm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 14, 2019
@Mark-Simulacrum
Copy link
Member

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 14, 2019

📌 Commit 1fd971c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019
…r=alexcrichton

Add a debug_assert to Vec::set_len

Following the precedent of rust-lang#52972, which found llogiq/bytecount#42.

(This may well make a test fail; let's see what Travis says.)
Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019
…r=alexcrichton

Add a debug_assert to Vec::set_len

Following the precedent of rust-lang#52972, which found llogiq/bytecount#42.

(This may well make a test fail; let's see what Travis says.)
bors added a commit that referenced this pull request Jan 14, 2019
Rollup of 8 pull requests

Successful merges:

 - #57043 (Fix poor worst case performance of set intersection)
 - #57480 (Clean up and fix a bug in query plumbing)
 - #57481 (provide suggestion for invalid boolean cast)
 - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
 - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)
 - #57572 (Unaccept `extern_in_paths`)
 - #57585 (Recover from item trailing semicolon)
 - #57589 (Add a debug_assert to Vec::set_len)

Failed merges:

r? @ghost
@bors bors merged commit 1fd971c into rust-lang:master Jan 15, 2019
@scottmcm scottmcm deleted the vec-set_len-debug_assert branch January 15, 2019 01:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants