Skip to content

librustc_codegen_ssa => 2018 #58322

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 9, 2019

Transitions librustc_codegen_ssa to Rust 2018; cc #58099

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2019
@@ -10,34 +10,19 @@
#![feature(nll)]
#![allow(unused_attributes)]
#![allow(dead_code)]
#![deny(rust_2018_idioms)]
#![allow(explicit_outlives_requirements)]
#![allow(elided_lifetimes_in_paths)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crate uses TyCtxt more than a few times, so elided_lifetimes_in_paths is allowed.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 10, 2019

📌 Commit be71fcc has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 10, 2019
…r=petrochenkov

librustc_codegen_ssa => 2018

Transitions `librustc_codegen_ssa` to Rust 2018; cc rust-lang#58099

r? @petrochenkov
@pietroalbini
Copy link
Member

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019
…r=petrochenkov

librustc_codegen_ssa => 2018

Transitions `librustc_codegen_ssa` to Rust 2018; cc rust-lang#58099

r? @petrochenkov
bors added a commit that referenced this pull request Feb 12, 2019
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost
@bors bors merged commit be71fcc into rust-lang:master Feb 12, 2019
@taiki-e taiki-e deleted the librustc_codegen_ssa-2018 branch February 12, 2019 08:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants