Skip to content

Revert removed #![feature(nll)] #58342

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Revert removed #![feature(nll)] #58342

merged 1 commit into from
Feb 12, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 10, 2019

In PRs related to #58099, #![feature(nll)] was removed from several crates.
This PR reverts it.

Related: #58265 (comment)

cc @Centril

r? @matthewjasper

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2019
@petrochenkov
Copy link
Contributor

Weird.
I thought feature(nll) is enabled fully and unconditionally on 2018 edition.
Why isn't that the case?

@RalfJung
Copy link
Member

AFAIK feature(nll) enables "full NLL" while on 2018, we are currently running "migration mode NLL". Also see #57895.

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 10, 2019

📌 Commit 2be0993 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019
Revert removed #![feature(nll)]

In PRs related to rust-lang#58099, `#![feature(nll)]` was removed from several crates.
This PR reverts it.

Related: rust-lang#58265 (comment)

cc @Centril

r? @matthewjasper
bors added a commit that referenced this pull request Feb 12, 2019
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost
@bors bors merged commit 2be0993 into rust-lang:master Feb 12, 2019
@taiki-e taiki-e deleted the nll branch February 12, 2019 08:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants