Skip to content

Remove UB in pointer tests #58536

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2019
Merged

Remove UB in pointer tests #58536

merged 2 commits into from
Feb 20, 2019

Conversation

LunaBorowska
Copy link
Contributor

UB found by Miri.

@rust-highfive

This comment has been minimized.

# to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2019
@Centril
Copy link
Contributor

Centril commented Feb 18, 2019

r? @RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned cramertj Feb 18, 2019
@RalfJung
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 18, 2019

📌 Commit 0cf1a91 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2019
@Centril
Copy link
Contributor

Centril commented Feb 18, 2019

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Feb 18, 2019
@kennytm
Rollup merge of rust-lang#58536 - xfix:remove-ub-in-pointer-tests, r=…
e3f75bf 
…RalfJung

Remove UB in pointer tests

UB found by Miri.
@kennytm kennytm mentioned this pull request Feb 18, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 18, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#58536 - xfix:remove-ub-in-pointer-tests, r=…
932ff67 
…RalfJung

Remove UB in pointer tests

UB found by Miri.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 18, 2019
Closed
@kennytm kennytm mentioned this pull request Feb 19, 2019
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 20, 2019
@kennytm
Rollup merge of rust-lang#58536 - xfix:remove-ub-in-pointer-tests, r=…
943fe1e 
…RalfJung

Remove UB in pointer tests

UB found by Miri.
bors added a commit that referenced this pull request Feb 20, 2019
@bors
Auto merge of #58578 - kennytm:rollup, r=kennytm
ff5dc27 
Rollup of 24 pull requests

Successful merges:

 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58044 (Make overflowing and wrapping negation const)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58384 (Fix tables display)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58409 (rustdoc: respect alternate flag when formatting impl trait)
 - #58456 (Remove no longer accurate diagnostic code about NLL)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58538 (Add missing fmt structs examples)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58546 (librustc_codegen_llvm => 2018)
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind)
 - #58553 (Use more impl header lifetime elision)
 - #58562 (Fix style nits)
 - #58565 (Fix typo in std::future::Future docs)
 - #58568 (Fix a transposition in driver.rs.)
 - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
 - #58576 (Stabilize iter::successors and iter::from_fn)
bors added a commit that referenced this pull request Feb 20, 2019
@bors
Auto merge of #58578 - kennytm:rollup, r=kennytm
f66e469 
Rollup of 24 pull requests

Successful merges:

 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58044 (Make overflowing and wrapping negation const)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58384 (Fix tables display)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58409 (rustdoc: respect alternate flag when formatting impl trait)
 - #58456 (Remove no longer accurate diagnostic code about NLL)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58538 (Add missing fmt structs examples)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58546 (librustc_codegen_llvm => 2018)
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind)
 - #58553 (Use more impl header lifetime elision)
 - #58562 (Fix style nits)
 - #58565 (Fix typo in std::future::Future docs)
 - #58568 (Fix a transposition in driver.rs.)
 - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
 - #58576 (Stabilize iter::successors and iter::from_fn)
@bors bors merged commit 0cf1a91 into rust-lang:master Feb 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LunaBorowska @rust-highfive @Centril @RalfJung @bors @cramertj