move some tests into subfolders #61526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Jun 10, 2019
|
In general, I think folders are good, but we've been a bit blocked on somebody trying to come up with a good organizational scheme. Overall, I think that we probably need some good way to index tests in more than one way -- e.g., sometimes it's useful to view them by rfc, other times by the area of the code. I had imagined picking one method as the primary way, and then using tags (e.g., |
|
I'll r+ this as a one-off though |
|
@bors r+ rollup |
|
📌 Commit 4c44d4a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 11, 2019
move some tests into subfolders This reduces the size of the test folders without making the moved tests harder to find. Is this kind of change desired/worth the effort?
@nikomatsakis I hope this is not a one-off; I think this PR moves us in the direction we want (tagging, good by-area/feature organization), and as long as PRs do that, let's keep r+ing them. :) |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 11, 2019
move some tests into subfolders This reduces the size of the test folders without making the moved tests harder to find. Is this kind of change desired/worth the effort?
This was referenced Jun 11, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 11, 2019
move some tests into subfolders This reduces the size of the test folders without making the moved tests harder to find. Is this kind of change desired/worth the effort?
bors
added a commit
that referenced
this pull request
Jun 11, 2019
Rollup of 11 pull requests Successful merges: - #61518 (Add loops to doc list of things not stable in const fn) - #61526 (move some tests into subfolders) - #61550 (Windows 10 SDK is also required now.) - #61606 (Remove some legacy proc macro flavors) - #61652 (Mention slice patterns in array) - #61686 (librustc_errors: Add some more documentation) - #61698 (typeck: Fix const generic in repeat param ICE.) - #61707 (Azure: retry failed awscli installs) - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone) - #61724 (core: use memcmp optimization for 128 bit integer slices) - #61726 (Use `for_each` in `Iterator::partition`) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Jun 11, 2019
Rollup of 11 pull requests Successful merges: - #61518 (Add loops to doc list of things not stable in const fn) - #61526 (move some tests into subfolders) - #61550 (Windows 10 SDK is also required now.) - #61606 (Remove some legacy proc macro flavors) - #61652 (Mention slice patterns in array) - #61686 (librustc_errors: Add some more documentation) - #61698 (typeck: Fix const generic in repeat param ICE.) - #61707 (Azure: retry failed awscli installs) - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone) - #61724 (core: use memcmp optimization for 128 bit integer slices) - #61726 (Use `for_each` in `Iterator::partition`) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of the test folders without making the moved tests harder to find.
Is this kind of change desired/worth the effort?