Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use for_each in Iterator::partition #61726

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 10, 2019

We already use this for unzip, but partition is not much different.

We already use this for `unzip`, but `partition` is not much different.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2019
@scottmcm
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jun 11, 2019

📌 Commit c127f53 has been approved by scottmcm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2019
@scottmcm scottmcm assigned scottmcm and unassigned alexcrichton Jun 11, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
Use `for_each` in `Iterator::partition`

We already use this for `unzip`, but `partition` is not much different.
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
Use `for_each` in `Iterator::partition`

We already use this for `unzip`, but `partition` is not much different.
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
Use `for_each` in `Iterator::partition`

We already use this for `unzip`, but `partition` is not much different.
bors added a commit that referenced this pull request Jun 11, 2019
Rollup of 11 pull requests

Successful merges:

 - #61518 (Add loops to doc list of things not stable in const fn)
 - #61526 (move some tests into subfolders)
 - #61550 (Windows 10 SDK is also required now.)
 - #61606 (Remove some legacy proc macro flavors)
 - #61652 (Mention slice patterns in array)
 - #61686 (librustc_errors: Add some more documentation)
 - #61698 (typeck: Fix const generic in repeat param ICE.)
 - #61707 (Azure: retry failed awscli installs)
 - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone)
 - #61724 (core: use memcmp optimization for 128 bit integer slices)
 - #61726 (Use `for_each` in `Iterator::partition`)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Jun 11, 2019
Rollup of 11 pull requests

Successful merges:

 - #61518 (Add loops to doc list of things not stable in const fn)
 - #61526 (move some tests into subfolders)
 - #61550 (Windows 10 SDK is also required now.)
 - #61606 (Remove some legacy proc macro flavors)
 - #61652 (Mention slice patterns in array)
 - #61686 (librustc_errors: Add some more documentation)
 - #61698 (typeck: Fix const generic in repeat param ICE.)
 - #61707 (Azure: retry failed awscli installs)
 - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone)
 - #61724 (core: use memcmp optimization for 128 bit integer slices)
 - #61726 (Use `for_each` in `Iterator::partition`)

Failed merges:

r? @ghost
@bors bors merged commit c127f53 into rust-lang:master Jun 12, 2019
@cuviper cuviper deleted the partition-for_each branch April 3, 2020 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants