Skip to content

don't assume we can *always* find a return type hint in async fn #65235

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

don't assume we can *always* find a return type hint in async fn #65235

merged 1 commit into from
Oct 16, 2019

Conversation

nikomatsakis
Copy link
Contributor

In particular, we sometimes cannot if there is an earlier error.

Fixes #65159

r? @cramertj, who reviewed the original PR

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2019
@nikomatsakis nikomatsakis mentioned this pull request Oct 9, 2019
Closed
@nikomatsakis nikomatsakis force-pushed the issue-65159-async-fn-return-ice branch from 0f16d25 to f7d0a8e Compare October 9, 2019 13:00
@cramertj
Copy link
Member

cramertj commented Oct 9, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 9, 2019

📌 Commit f7d0a8e has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2019
@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Oct 9, 2019 •
edited
Loading

@bors p=1 -- ICE/regression in async-await

@nikomatsakis nikomatsakis mentioned this pull request Oct 9, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request Oct 9, 2019
@Centril
Rollup merge of rust-lang#65235 - nikomatsakis:issue-65159-async-fn-r…
5a24534 
…eturn-ice, r=cramertj

don't assume we can *always* find a return type hint in async fn

In particular, we sometimes cannot if there is an earlier error.

Fixes rust-lang#65159

r? @cramertj, who reviewed the original PR
@Centril Centril mentioned this pull request Oct 9, 2019
Closed
@bors bors added the rollup A PR which is a rollup label Oct 9, 2019
@Centril Centril removed the rollup A PR which is a rollup label Oct 9, 2019
@bors
Copy link
Collaborator

bors commented Oct 9, 2019

⌛ Testing commit 5a24534 with merge 88624206022c8627d731d4dc9725d6c384e8c02a...

@bors
Copy link
Collaborator

bors commented Oct 9, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2019
@nikomatsakis
Copy link
Contributor Author

I can't really tell what happened with this build -- did something go wrong? All I see is "cancelled by @alexcrichton"

@pietroalbini
Copy link
Member

@bors r-
(homu state messed up after a redeploy)

@nikomatsakis "cancelled by alex" is just the other builders being killed because another one failed. Azure Pipelines requires using a personal token when cancelling a build and it just so happens it's Alex's one.

Seems like the i686-gnu builder is what caused the failure though. Build log

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2019
@nikomatsakis
Copy link
Contributor Author

@pietroalbini thanks. I .. don't really have any idea how this PR caused that error, though. Huh.

@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Oct 11, 2019 •
edited
Loading 

2019-10-09T20:25:09.7693690Z Building stage0 tool tidy (i686-unknown-linux-gnu)
2019-10-09T20:25:10.0430774Z �[0m�[0m�[1m�[32m   Compiling�[0m proc-macro2 v0.4.30
2019-10-09T20:25:10.0431404Z �[0m�[0m�[1m�[32m   Compiling�[0m unicode-xid v0.1.0
2019-10-09T20:25:10.2314576Z [RUSTC-TIMING] unicode_xid test:false 0.183
2019-10-09T20:25:10.2358871Z �[0m�[0m�[1m�[32m   Compiling�[0m syn v0.15.35
2019-10-09T20:25:11.4312004Z [RUSTC-TIMING] build_script_build test:false 1.384
2019-10-09T20:25:11.4317763Z [RUSTC-TIMING] build_script_build test:false 1.191

is this "RUSTC-TIMING" stuff normal, or does that indicate some special mode? (cc @pietroalbini)

@pietroalbini
Copy link
Member

Yeah, it's normal. On CI rustbuild is configured to emit detailed timings for each step so infra can analyze slowdowns more easily.

@nikomatsakis
don't assume we can *always* find a return type hint in async fn
48fff6f 
In particular, we sometimes cannot if there is an earlier error.
@nikomatsakis nikomatsakis force-pushed the issue-65159-async-fn-return-ice branch from f7d0a8e to 48fff6f Compare October 11, 2019 21:00
@nikomatsakis
Copy link
Contributor Author

ok I rebased and ran my local tests. Due to #63520 x.py test didn't run to completion, but I'll delete that test locally and try again. Weird that the bot above seemed to die building libstd.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 15, 2019
@bors
Copy link
Collaborator

bors commented Oct 15, 2019

📌 Commit 48fff6f has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2019
@bors
Copy link
Collaborator

bors commented Oct 15, 2019

⌛ Testing commit 48fff6f with merge a0192c324d7eeda991ed8dc8197f16ac683df59a...

Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
@Centril
Rollup merge of rust-lang#65235 - nikomatsakis:issue-65159-async-fn-r…
2e686ef 
…eturn-ice, r=cramertj

don't assume we can *always* find a return type hint in async fn

In particular, we sometimes cannot if there is an earlier error.

Fixes rust-lang#65159

r? @cramertj, who reviewed the original PR
@Centril Centril mentioned this pull request Oct 15, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Oct 15, 2019

@bors retry rolled up. :)

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

⌛ Testing commit 48fff6f with merge e43da6e749cfc2153a906d2b956e2e77801f515d...

Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
@Centril
Rollup merge of rust-lang#65235 - nikomatsakis:issue-65159-async-fn-r…
fd1cf87 
…eturn-ice, r=cramertj

don't assume we can *always* find a return type hint in async fn

In particular, we sometimes cannot if there is an earlier error.

Fixes rust-lang#65159

r? @cramertj, who reviewed the original PR
@Centril Centril mentioned this pull request Oct 15, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Oct 15, 2019

@bors retry rolled up. :)

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

⌛ Testing commit 48fff6f with merge 70c5542f0d41f1dc75cc56e0d9a1b01c00e736e6...

tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019
@tmandry
Rollup merge of rust-lang#65235 - nikomatsakis:issue-65159-async-fn-r…
bbf4eb3 
…eturn-ice, r=cramertj

don't assume we can *always* find a return type hint in async fn

In particular, we sometimes cannot if there is an earlier error.

Fixes rust-lang#65159

r? @cramertj, who reviewed the original PR
@tmandry tmandry mentioned this pull request Oct 15, 2019
Merged
@tmandry
Copy link
Member

tmandry commented Oct 15, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Oct 15, 2019
@bors
Auto merge of #65454 - tmandry:rollup-0k6jiik, r=tmandry
f54911c 
Rollup of 14 pull requests

Successful merges:

 - #64603 (Reducing spurious unused lifetime warnings.)
 - #64623 (Remove last uses of gensyms)
 - #65235 (don't assume we can *always* find a return type hint in async fn)
 - #65242 (Fix suggestion to constrain trait for method to be found)
 - #65265 (Cleanup librustc mir err codes)
 - #65293 (Optimize `try_expand_impl_trait_type`)
 - #65307 (Try fix incorrect "explicit lifetime name needed")
 - #65308 (Add long error explanation for E0574)
 - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members)
 - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.)
 - #65402 (Add troubleshooting section to PGO chapter in rustc book.)
 - #65425 (Optimize `BitIter`)
 - #65438 (Organize `never_type`  tests)
 - #65444 (Implement AsRef<[T]> for List<T>)

Failed merges:

 - #65390 (Add long error explanation for E0576)

r? @ghost
@bors
Copy link
Collaborator

bors commented Oct 16, 2019

⌛ Testing commit 48fff6f with merge f54911c...

@bors bors merged commit 48fff6f into rust-lang:master Oct 16, 2019
@estebank estebank added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 17, 2019
@estebank
Copy link
Contributor

Nominating as fix for #65500.

@estebank estebank added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 17, 2019
@Centril
Copy link
Contributor

Centril commented Oct 17, 2019

@estebank backport was declined for the PR this depends on (#64999 (comment)).

@estebank
Copy link
Contributor

@Centril ack. Please remove the label, on mobile right now.

@Centril Centril removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 18, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly async fn ICE
9 participants
@nikomatsakis @cramertj @bors @pietroalbini @jonhoo @Centril @tmandry @estebank @rust-highfive