Skip to content

Cleanup librustc mir err codes #65265

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2019
Merged

Cleanup librustc mir err codes #65265

merged 4 commits into from
Oct 16, 2019

Conversation

GuillaumeGomez
Copy link
Member

Three things are done in this PR:

  • Sort error codes
  • Uncomment an error code long error explanation (they should never be commented)
  • Unify explanations

@rust-highfive
Copy link
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2019
@Mark-Simulacrum
Copy link
Member

Can you give rational for sorting the error codes? To be frank, it just seems like an excellent way to cause merge conflicts and is otherwise useless - unless I'm missing something. If we had only a couple error codes it might make more sense but I usually can't fit a single error code explanation on screen at a time, much less see two at once to know that they're sorted.

@GuillaumeGomez
Copy link
Member Author

Doesn't have much interest in itself. It's just more "clean". However, if you go through missing error codes like I'm currently doing, it helps a lot because generally the error codes close to the one you're writing have pretty close examples that you can use. All depending on the point of view. :)

@Mark-Simulacrum
Copy link
Member

r=me with the box syntax removed

@GuillaumeGomez
Copy link
Member Author

I couldn't find out how to get the error without the box syntax (which is very strange).

@Mark-Simulacrum
Copy link
Member

I guess you can technically get it via vec![10] because that uses box internally, and I'd probably prefer that (it also generates other error codes though). We just don't have any allocating const fn functions to fall back on which is required to get this error, since we don't support it :)

@varkor varkor assigned Mark-Simulacrum and unassigned varkor Oct 10, 2019
@GuillaumeGomez GuillaumeGomez force-pushed the cleanup-librustc_mir-err-codes branch from 993d3df to 06a02b5 Compare October 10, 2019 22:15
@GuillaumeGomez
Copy link
Member Author

Nicely found! Thanks a lot for the tip!

@bors: r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Oct 10, 2019

📌 Commit 06a02b5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65265 - GuillaumeGomez:cleanup-librustc_mir…
1d70283 
…-err-codes, r=Mark-Simulacrum

Cleanup librustc mir err codes

Three things are done in this PR:

 * Sort error codes
 * Uncomment an error code long error explanation (they should **never** be commented)
 * Unify explanations
@tmandry tmandry mentioned this pull request Oct 11, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65297 - tmandry:rollup-pe7a2i2, r=tmandry
c7c6cbf 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#64337 (libstd: Fix typos in doc)
 - rust-lang#64986 (Function pointers as const generic arguments)
 - rust-lang#65048 (Added doc about behavior of extend on HashMap)
 - rust-lang#65191 (Add some regression tests)
 - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation)
 - rust-lang#65205 (Add long error explanation for E0568)
 - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization))
 - rust-lang#65248 (Suggest `if let` on `let` refutable binding)
 - rust-lang#65252 (expand: Simplify expansion of derives)
 - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw)
 - rust-lang#65265 (Cleanup librustc mir err codes)
 - rust-lang#65266 (Mark Path::join as must_use)
 - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes)
 - rust-lang#65277 (Query generator kind for error reporting)
 - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR)
 - rust-lang#65289 (Fix suggested bound addition diagnostic)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 11, 2019
@Centril
Rollup merge of rust-lang#65299 - tmandry:rollup-pe7a2i2, r=tmandry
ebc1d34 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#64337 (libstd: Fix typos in doc)
 - rust-lang#64986 (Function pointers as const generic arguments)
 - rust-lang#65048 (Added doc about behavior of extend on HashMap)
 - rust-lang#65191 (Add some regression tests)
 - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation)
 - rust-lang#65205 (Add long error explanation for E0568)
 - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization))
 - rust-lang#65248 (Suggest `if let` on `let` refutable binding)
 - rust-lang#65252 (expand: Simplify expansion of derives)
 - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw)
 - rust-lang#65265 (Cleanup librustc mir err codes)
 - rust-lang#65266 (Mark Path::join as must_use)
 - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes)
 - rust-lang#65277 (Query generator kind for error reporting)
 - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR)
 - rust-lang#65289 (Fix suggested bound addition diagnostic)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 14, 2019
@Centril
Rollup merge of rust-lang#65265 - GuillaumeGomez:cleanup-librustc_mir…
28b6bb8 
…-err-codes, r=Mark-Simulacrum

Cleanup librustc mir err codes

Three things are done in this PR:

 * Sort error codes
 * Uncomment an error code long error explanation (they should **never** be commented)
 * Unify explanations
@Centril Centril mentioned this pull request Oct 14, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Oct 14, 2019

This seems to reproduce diffs under --compare-mode=nll -- please check that it doesn't or --bless otherwise. @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2019
@GuillaumeGomez GuillaumeGomez force-pushed the cleanup-librustc_mir-err-codes branch from 06a02b5 to d4e3e6b Compare October 14, 2019 11:01
@GuillaumeGomez
Copy link
Member Author

Re-ran the tests so let's r+ it again.

@bors: r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

📌 Commit d4e3e6b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019
@tmandry
Rollup merge of rust-lang#65265 - GuillaumeGomez:cleanup-librustc_mir…
8f09085 
…-err-codes, r=Mark-Simulacrum

Cleanup librustc mir err codes

Three things are done in this PR:

 * Sort error codes
 * Uncomment an error code long error explanation (they should **never** be commented)
 * Unify explanations
@tmandry tmandry mentioned this pull request Oct 15, 2019
Merged
bors added a commit that referenced this pull request Oct 15, 2019
@bors
Auto merge of #65454 - tmandry:rollup-0k6jiik, r=tmandry
f54911c 
Rollup of 14 pull requests

Successful merges:

 - #64603 (Reducing spurious unused lifetime warnings.)
 - #64623 (Remove last uses of gensyms)
 - #65235 (don't assume we can *always* find a return type hint in async fn)
 - #65242 (Fix suggestion to constrain trait for method to be found)
 - #65265 (Cleanup librustc mir err codes)
 - #65293 (Optimize `try_expand_impl_trait_type`)
 - #65307 (Try fix incorrect "explicit lifetime name needed")
 - #65308 (Add long error explanation for E0574)
 - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members)
 - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.)
 - #65402 (Add troubleshooting section to PGO chapter in rustc book.)
 - #65425 (Optimize `BitIter`)
 - #65438 (Organize `never_type`  tests)
 - #65444 (Implement AsRef<[T]> for List<T>)

Failed merges:

 - #65390 (Add long error explanation for E0576)

r? @ghost
@bors bors merged commit d4e3e6b into rust-lang:master Oct 16, 2019
@GuillaumeGomez GuillaumeGomez deleted the cleanup-librustc_mir-err-codes branch October 16, 2019 08:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-highfive @Mark-Simulacrum @bors @Centril @varkor