Skip to content

Remove PartialEq and Eq from the SpecialDerives. #65892

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2019
Merged

Remove PartialEq and Eq from the SpecialDerives. #65892

merged 3 commits into from
Nov 6, 2019

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Oct 28, 2019 •
edited
Loading

Now that PR #65519 landed, this is the follow-on work of removing PartialEq and Eq from the set of SpecialDerives .

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2019
@pnkfelix
Copy link
Member Author

r? @petrochenkov

varkor
varkor reviewed Oct 28, 2019
View reviewed changes
@petrochenkov
Copy link
Contributor

hir::lowering::Resolver::has_derives can be removed now and struct SpecialDerives can be moved back into libsyntax_expand where it was before fb12c70.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2019
@pnkfelix pnkfelix added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2019
petrochenkov
petrochenkov reviewed Oct 30, 2019
View reviewed changes
@petrochenkov
Copy link
Contributor

LGTM beside the naming question.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2019
@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 4, 2019

@bors r=petrochenkov rollup

@bors
Copy link
Collaborator

bors commented Nov 4, 2019

📌 Commit 72eb8a0386e62af970c320cbf28c91a68077a781 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 4, 2019
@bors
Copy link
Collaborator

bors commented Nov 4, 2019

☔ The latest upstream changes (presumably #65835) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2019
@pnkfelix pnkfelix force-pushed the trim-special-derives branch from 72eb8a0 to 9924361 Compare November 5, 2019 13:59
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 5, 2019

📌 Commit 9924361 has been approved by petrochenkov

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 5, 2019
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 5, 2019
@Centril
Rollup merge of rust-lang#65892 - pnkfelix:trim-special-derives, r=pe…
ae95e24 
…trochenkov

Remove `PartialEq` and `Eq` from the `SpecialDerives`.

Now that PR rust-lang#65519 landed, this is the follow-on work of removing `PartialEq` and `Eq` from the set of `SpecialDerives` .
@Centril Centril mentioned this pull request Nov 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 6, 2019
@Centril
Rollup merge of rust-lang#65892 - pnkfelix:trim-special-derives, r=pe…
5910116 
…trochenkov

Remove `PartialEq` and `Eq` from the `SpecialDerives`.

Now that PR rust-lang#65519 landed, this is the follow-on work of removing `PartialEq` and `Eq` from the set of `SpecialDerives` .
@Centril Centril mentioned this pull request Nov 6, 2019
Merged
bors added a commit that referenced this pull request Nov 6, 2019
@bors
Auto merge of #66141 - Centril:rollup-n2fcvp9, r=Centril
e4931ea 
Rollup of 11 pull requests

Successful merges:

 - #65892 (Remove `PartialEq` and `Eq` from the `SpecialDerives`.)
 - #66014 (Show type parameter name and definition in type mismatch error messages )
 - #66027 (Move has_panic_handler to query)
 - #66054 (syntax: Avoid span arithmetic for delimiter tokens)
 - #66068 (use silent emitter for rustdoc highlighting pass)
 - #66081 (let caller of check_ptr_access_align control the error message)
 - #66093 (Do not ICE with a precision flag in formatting str and no format arguments)
 - #66098 (Detect `::` -> `:` typo when involving turbofish)
 - #66101 (Tweak type mismatch caused by break on tail expr)
 - #66106 (Fix typo in explanation of `E0080`)
 - #66115 (rustc: remove "GlobalMetaData" dead code from hir::map::definitions.)

Failed merges:

r? @ghost
@bors bors merged commit 9924361 into rust-lang:master Nov 6, 2019
@SimonSapin SimonSapin mentioned this pull request Nov 12, 2019
Closed
@petrochenkov petrochenkov mentioned this pull request Dec 15, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Centril Centril Centril left review comments

@varkor varkor varkor left review comments

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pnkfelix @rust-highfive @petrochenkov @bors @Centril @varkor @davidtwco