Skip to content

Do not ICE with a precision flag in formatting str and no format arguments #66093

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

Do not ICE with a precision flag in formatting str and no format arguments #66093

merged 1 commit into from
Nov 6, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Nov 4, 2019

Fix #66065.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2019
@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2019
@estebank
Copy link
Contributor Author

estebank commented Nov 4, 2019

@rust-lang/compiler sorry for the wide scatter approach, but this is a tiny PR that would fix a stable ICE and would like to merge it and backport before 1.39 leaves the station (although I understand if declined).

@jonas-schievink
Copy link
Contributor

The 1.39 beta->stable promotion has already happened earlier today, so I'm not sure how likely this is to happen. cc @rust-lang/release

@estebank
Copy link
Contributor Author

estebank commented Nov 4, 2019

@jonas-schievink fair. Does that mean that 1.40-beta has already been cut? In that case it can follow regular backporting to 1.40-beta later in the week/next week.

This is not a critical ICE, it just felt to me way too easy to trigger.

@jonas-schievink
Copy link
Contributor

AFAIK that will be done tomorrow (the master->beta promotion, that is)

@Mark-Simulacrum
Copy link
Member

1.39 has been fully cut, any backports targeting beta in the release week need to be quite significant impact (e.g., ICE -> error fixes almost certainly don't qualify IMO). 1.40 beta has not yet been cut (that will happen tomorrow).

Centril
Centril reviewed Nov 5, 2019
View reviewed changes
@Centril
Copy link
Contributor

Centril commented Nov 5, 2019

r? @Centril r=me with comment addressed.

@rust-highfive rust-highfive assigned Centril and unassigned alexcrichton Nov 5, 2019
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2019
@estebank
Copy link
Contributor Author

estebank commented Nov 5, 2019

@bors r=Centril

@bors
Copy link
Collaborator

bors commented Nov 5, 2019

📌 Commit bbd7f5c has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2019
@estebank estebank changed the title Do not ICE whith a precision flag in formatting str and no format arguments Do not ICE with a precision flag in formatting str and no format arguments Nov 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 5, 2019
@Centril
Rollup merge of rust-lang#66093 - estebank:fmt-ice, r=Centril
c17de6b 
Do not ICE with a precision flag in formatting str and no format arguments

Fix rust-lang#66065.
@Centril Centril mentioned this pull request Nov 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 6, 2019
@Centril
Rollup merge of rust-lang#66093 - estebank:fmt-ice, r=Centril
7d66a09 
Do not ICE with a precision flag in formatting str and no format arguments

Fix rust-lang#66065.
@Centril Centril mentioned this pull request Nov 6, 2019
Merged
bors added a commit that referenced this pull request Nov 6, 2019
@bors
Auto merge of #66141 - Centril:rollup-n2fcvp9, r=Centril
e4931ea 
Rollup of 11 pull requests

Successful merges:

 - #65892 (Remove `PartialEq` and `Eq` from the `SpecialDerives`.)
 - #66014 (Show type parameter name and definition in type mismatch error messages )
 - #66027 (Move has_panic_handler to query)
 - #66054 (syntax: Avoid span arithmetic for delimiter tokens)
 - #66068 (use silent emitter for rustdoc highlighting pass)
 - #66081 (let caller of check_ptr_access_align control the error message)
 - #66093 (Do not ICE with a precision flag in formatting str and no format arguments)
 - #66098 (Detect `::` -> `:` typo when involving turbofish)
 - #66101 (Tweak type mismatch caused by break on tail expr)
 - #66106 (Fix typo in explanation of `E0080`)
 - #66115 (rustc: remove "GlobalMetaData" dead code from hir::map::definitions.)

Failed merges:

r? @ghost
@bors bors merged commit bbd7f5c into rust-lang:master Nov 6, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Nov 7, 2019

Discussed in T-compiler meeting. beta-accepted, and stable-accepted (with understanding that this is not very high priority to fix and that release team is trusted to make the call with respect to when/whether to issue a point release).

@pnkfelix pnkfelix added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Nov 7, 2019
@SimonSapin SimonSapin mentioned this pull request Nov 12, 2019
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Dec 5, 2019
Merged
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 5, 2019
bors added a commit that referenced this pull request Dec 7, 2019
@bors
Auto merge of #67063 - Mark-Simulacrum:beta-backports, r=Mark-Simulacrum
3f7f341 
[beta] backports

This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.

 * Handle non_exhaustive in borrow checking #66722
 * Do not ICE on trait aliases with missing obligations #66392
 * Do not ICE in `if` without `else` in `async fn` #66391
 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390
 * Do not ICE on recovery from unmet associated type bound obligation #66388
 * find_deprecation: deprecation attr may be ill-formed meta. #66381
 * parser: don't use `unreachable!()` in `fn unexpected`. #66361
 * Undo an assert causing an ICE until we fix the underlying problem #66250
 * Do not ICE with a precision flag in formatting str and no format arguments #66093
 * Fix two OOM issues related to `ConstProp` #66394
bors added a commit that referenced this pull request Dec 8, 2019
@bors
Auto merge of #67063 - Mark-Simulacrum:beta-backports, r=Mark-Simulacrum
b509d9b 
[beta] backports

This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.

 * Handle non_exhaustive in borrow checking #66722
 * Do not ICE on trait aliases with missing obligations #66392
 * Do not ICE in `if` without `else` in `async fn` #66391
 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390
 * Do not ICE on recovery from unmet associated type bound obligation #66388
 * find_deprecation: deprecation attr may be ill-formed meta. #66381
 * parser: don't use `unreachable!()` in `fn unexpected`. #66361
 * Undo an assert causing an ICE until we fix the underlying problem #66250
 * Do not ICE with a precision flag in formatting str and no format arguments #66093
 * Fix two OOM issues related to `ConstProp` #66394
@Mark-Simulacrum Mark-Simulacrum removed stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Dec 14, 2019
@estebank estebank deleted the fmt-ice branch November 9, 2023 05:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fmt::Display compiler panic: len is 0 but the index is 0
8 participants
@estebank @rust-highfive @jonas-schievink @Mark-Simulacrum @Centril @bors @pnkfelix @alexcrichton