-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Do not ICE with a precision flag in formatting str and no format arguments #66093
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@rust-lang/compiler sorry for the wide scatter approach, but this is a tiny PR that would fix a stable ICE and would like to merge it and backport before 1.39 leaves the station (although I understand if declined). |
The 1.39 beta->stable promotion has already happened earlier today, so I'm not sure how likely this is to happen. cc @rust-lang/release |
@jonas-schievink fair. Does that mean that 1.40-beta has already been cut? In that case it can follow regular backporting to 1.40-beta later in the week/next week. This is not a critical ICE, it just felt to me way too easy to trigger. |
AFAIK that will be done tomorrow (the master->beta promotion, that is) |
1.39 has been fully cut, any backports targeting beta in the release week need to be quite significant impact (e.g., ICE -> error fixes almost certainly don't qualify IMO). 1.40 beta has not yet been cut (that will happen tomorrow). |
r? @Centril r=me with comment addressed. |
@bors r=Centril |
📌 Commit bbd7f5c has been approved by |
Do not ICE with a precision flag in formatting str and no format arguments Fix rust-lang#66065.
Do not ICE with a precision flag in formatting str and no format arguments Fix rust-lang#66065.
Rollup of 11 pull requests Successful merges: - #65892 (Remove `PartialEq` and `Eq` from the `SpecialDerives`.) - #66014 (Show type parameter name and definition in type mismatch error messages ) - #66027 (Move has_panic_handler to query) - #66054 (syntax: Avoid span arithmetic for delimiter tokens) - #66068 (use silent emitter for rustdoc highlighting pass) - #66081 (let caller of check_ptr_access_align control the error message) - #66093 (Do not ICE with a precision flag in formatting str and no format arguments) - #66098 (Detect `::` -> `:` typo when involving turbofish) - #66101 (Tweak type mismatch caused by break on tail expr) - #66106 (Fix typo in explanation of `E0080`) - #66115 (rustc: remove "GlobalMetaData" dead code from hir::map::definitions.) Failed merges: r? @ghost
Discussed in T-compiler meeting. beta-accepted, and stable-accepted (with understanding that this is not very high priority to fix and that release team is trusted to make the call with respect to when/whether to issue a point release). |
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
Fix #66065.