Skip to content

Do not ICE on unnamed future #67289

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2019
Merged

Do not ICE on unnamed future #67289

merged 1 commit into from
Dec 15, 2019

Conversation

estebank
Copy link
Contributor

Fix #67252.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2019
@estebank
Copy link
Contributor Author

Depending on how quickly we land this it might need a beta backport after the next beta release.

@estebank estebank added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 13, 2019
Centril
Centril reviewed Dec 14, 2019
View reviewed changes
@Centril
Copy link
Contributor

Centril commented Dec 14, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned eddyb Dec 14, 2019
@Centril Centril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2019
@Mark-Simulacrum
Copy link
Member

@estebank so the beta-nomination here is for "current master", i.e., we want this in 1.41, not the release next week, right? I am skipping it for beta backports at least so it probably won't get in.

@estebank
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Collaborator

bors commented Dec 15, 2019

📌 Commit e08944f has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 15, 2019
@Centril
Rollup merge of rust-lang#67289 - estebank:unnamed-closure, r=Centril
8e2689c 
Do not ICE on unnamed future

Fix rust-lang#67252.
@Centril Centril mentioned this pull request Dec 15, 2019
Merged
bors added a commit that referenced this pull request Dec 15, 2019
@bors
Auto merge of #67310 - Centril:rollup-22jiyow, r=Centril
a605441 
Rollup of 6 pull requests

Successful merges:

 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)
 - #67289 (Do not ICE on unnamed future)
 - #67300 (Restore original implementation of Vec::retain)
 - #67305 (Doc typo)

Failed merges:

r? @ghost
@bors bors merged commit e08944f into rust-lang:master Dec 15, 2019
@pnkfelix
Copy link
Member

discussed in T-compiler meeting. beta-accepted.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 19, 2019
@jsartisohn jsartisohn mentioned this pull request Dec 26, 2019
Closed
@csmoe csmoe mentioned this pull request Jan 3, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Jan 13, 2020
Merged
@jonas-schievink
Copy link
Contributor

This seems to be on the beta branch already

@jonas-schievink jonas-schievink removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 13, 2020
bors added a commit that referenced this pull request Jan 14, 2020
@bors
Auto merge of #68189 - jonas-schievink:beta-next, r=Mark-Simulacrum
965ce16 
[Beta] Backports

I did not include #67134 and #67289 since they seem to be on beta already.

* Fix up Command Debug output when arg0 is specified. #67219
* Do not ICE on unnamed future #67289
* Don't suppress move errors for union fields #67314
* Reenable static linking of libstdc++ on windows-gnu #67410
* Use the correct type for static qualifs #67621
* Treat extern statics just like statics in the "const pointer to static" representation #67630
* Do not ICE on lifetime error involving closures #67687
@estebank estebank deleted the unnamed-closure branch November 9, 2023 05:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: no name for expr ||
8 participants
@estebank @rust-highfive @Centril @Mark-Simulacrum @bors @pnkfelix @jonas-schievink @eddyb