Skip to content

Do not ICE on lifetime error involving closures #67687

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2019
Merged

Do not ICE on lifetime error involving closures #67687

merged 1 commit into from
Dec 30, 2019
+38 −2

Conversation

estebank
Copy link
Contributor

Fix #67634.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2019
@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2019
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 29, 2019

📌 Commit 5e1b366 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2019
@matthewjasper matthewjasper mentioned this pull request Dec 29, 2019
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 29, 2019
@Dylan-DPC
Rollup merge of rust-lang#67687 - estebank:issue-67634, r=matthewjasper
18a51bd 
Do not ICE on lifetime error involving closures

Fix rust-lang#67634.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 29, 2019
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 30, 2019
@JohnTitor
Rollup merge of rust-lang#67687 - estebank:issue-67634, r=matthewjasper
3928ace 
Do not ICE on lifetime error involving closures

Fix rust-lang#67634.
@JohnTitor JohnTitor mentioned this pull request Dec 30, 2019
Merged
bors added a commit that referenced this pull request Dec 30, 2019
@bors
Auto merge of #67721 - JohnTitor:rollup-o8zm4r9, r=JohnTitor
d297b19 
Rollup of 10 pull requests

Successful merges:

 - #64273 (Stabilize attribute macros on inline modules)
 - #67287 (typeck: note other end-point when checking range pats)
 - #67564 (docs: Iterator adapters have unspecified results after a panic)
 - #67622 (Some keyword documentation.)
 - #67657 (Clean up const-hack PRs now that const if / match exist.)
 - #67677 (resolve: Minor cleanup of duplicate macro reexports)
 - #67687 (Do not ICE on lifetime error involving closures)
 - #67698 (Move reachable_set and diagnostic_items to librustc_passes.)
 - #67701 (tidy: Enforce formatting rather than just check it if `--bless` is specified)
 - #67715 (Typo fix)

Failed merges:

r? @ghost
@bors bors merged commit 5e1b366 into rust-lang:master Dec 30, 2019
@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 9, 2020
@pnkfelix
Copy link
Member

pnkfelix commented Jan 9, 2020

Discussed at T-compiler meeting. (Two weeks in a row, even.)

beta-accepted and stable-accepted.

@pnkfelix pnkfelix added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Jan 9, 2020
@jonas-schievink jonas-schievink mentioned this pull request Jan 13, 2020
Merged
bors added a commit that referenced this pull request Jan 14, 2020
@bors
Auto merge of #68189 - jonas-schievink:beta-next, r=Mark-Simulacrum
965ce16 
[Beta] Backports

I did not include #67134 and #67289 since they seem to be on beta already.

* Fix up Command Debug output when arg0 is specified. #67219
* Do not ICE on unnamed future #67289
* Don't suppress move errors for union fields #67314
* Reenable static linking of libstdc++ on windows-gnu #67410
* Use the correct type for static qualifs #67621
* Treat extern statics just like statics in the "const pointer to static" representation #67630
* Do not ICE on lifetime error involving closures #67687
@jonas-schievink jonas-schievink removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 17, 2020
@Mark-Simulacrum Mark-Simulacrum removed stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jan 31, 2020
@estebank estebank deleted the issue-67634 branch November 9, 2023 05:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: no name for expr |a|
7 participants
@estebank @rust-highfive @matthewjasper @bors @pnkfelix @jonas-schievink @Mark-Simulacrum