reuse capacity variable in slice::repeat
#67576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
king6cong
force-pushed
the
slice_repeat
branch
from
53c14ce to
3c56a65
Compare
|
@bors r+ rollup |
|
📌 Commit 3c56a65 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
tesuji
reviewed
Dec 24, 2019
| @@ -487,8 +488,7 @@ impl<T> [T] { | |||
| rem_len, | |||
| ); | |||
| // `buf.len() + rem_len` equals to `buf.capacity()` (`= self.len() * n`). | |||
aidanhs
added a commit
to aidanhs/rust
that referenced
this pull request
Dec 24, 2019
reuse `capacity` variable in slice::repeat None
bjorn3
reviewed
Dec 24, 2019
| @@ -450,7 +450,8 @@ impl<T> [T] { | |||
| // and `rem` is the remaining part of `n`. | |||
|
|
|||
| // Using `Vec` to access `set_len()`. | |||
| let mut buf = Vec::with_capacity(self.len().checked_mul(n).expect("capacity overflow")); | |||
| let capacity = self.len().checked_mul(n).expect("capacity overflow"); | |||
There was a problem hiding this comment.
Suggested change
| let capacity = self.len().checked_mul(n).expect("capacity overflow"); | |
| let result_len = self.len().checked_mul(n).expect("length overflow in <[T]>::repeat"); |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 26, 2019
reuse `capacity` variable in slice::repeat None
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 26, 2019
reuse `capacity` variable in slice::repeat None
bors
added a commit
that referenced
this pull request
Dec 26, 2019
Rollup of 6 pull requests Successful merges: - #67576 (reuse `capacity` variable in slice::repeat) - #67598 (Fix ICE / miscompilation when inlining simd shuffle intrinsic in MIR.) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67604 (Add Scalar::to_(u|i)16 methods) - #67605 (tidy: change msdn links to newer locations) - #67617 (Remove `compiler_builtins_lib` documentation) Failed merges: r? @ghost
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 26, 2019
reuse `capacity` variable in slice::repeat None
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 26, 2019
reuse `capacity` variable in slice::repeat None
bors
added a commit
that referenced
this pull request
Dec 26, 2019
Rollup of 12 pull requests Successful merges: - #67112 (Refactor expression parsing thoroughly) - #67192 (Various const eval and pattern matching ICE fixes) - #67287 (typeck: note other end-point when checking range pats) - #67459 (prune ill-conceived BTreeMap iter_mut assertion and test its mutability) - #67576 (reuse `capacity` variable in slice::repeat) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67614 (Set callbacks globally) - #67617 (Remove `compiler_builtins_lib` documentation) - #67629 (Remove redundant link texts) - #67632 (Convert collapsed to shortcut reference links) - #67633 (Update .mailmap) - #67635 (Document safety of Path casting) Failed merges: r? @ghost
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 27, 2019
reuse `capacity` variable in slice::repeat None
oli-obk
added a commit
to oli-obk/rust
that referenced
this pull request
Dec 27, 2019
reuse `capacity` variable in slice::repeat None
bors
added a commit
that referenced
this pull request
Dec 28, 2019
Rollup of 15 pull requests Successful merges: - #65244 (add IntoFuture trait and support for await) - #67576 (reuse `capacity` variable in slice::repeat) - #67588 (Use NonNull in slice::Iter and slice::IterMut.) - #67594 (Update libc to 0.2.66) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67604 (Add Scalar::to_(u|i)16 methods) - #67617 (Remove `compiler_builtins_lib` documentation) - #67621 (Use the correct type for static qualifs) - #67629 (Remove redundant link texts) - #67632 (Convert collapsed to shortcut reference links) - #67633 (Update .mailmap) - #67635 (Document safety of Path casting) - #67654 (Add regression test for old NLL ICE) - #67659 (Stabilize the `matches!` macro) - #67664 (Fix some mailmap entries) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.