Add Scalar::to_(u|i)16 methods #67604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Dec 25, 2019
Centril
reviewed
Dec 25, 2019
Centril
reviewed
Dec 25, 2019
RalfJung
reviewed
Dec 25, 2019
RalfJung
reviewed
Dec 25, 2019
|
LGTM, thanks! @bors r+ |
|
📌 Commit dfcc44d has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 26, 2019
…r=RalfJung Add Scalar::to_(u|i)16 methods r? @RalfJung
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 26, 2019
…r=RalfJung Add Scalar::to_(u|i)16 methods r? @RalfJung
bors
added a commit
that referenced
this pull request
Dec 26, 2019
Rollup of 6 pull requests Successful merges: - #67576 (reuse `capacity` variable in slice::repeat) - #67598 (Fix ICE / miscompilation when inlining simd shuffle intrinsic in MIR.) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67604 (Add Scalar::to_(u|i)16 methods) - #67605 (tidy: change msdn links to newer locations) - #67617 (Remove `compiler_builtins_lib` documentation) Failed merges: r? @ghost
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 26, 2019
…r=RalfJung Add Scalar::to_(u|i)16 methods r? @RalfJung
oli-obk
added a commit
to oli-obk/rust
that referenced
this pull request
Dec 27, 2019
…r=RalfJung Add Scalar::to_(u|i)16 methods r? @RalfJung
bors
added a commit
that referenced
this pull request
Dec 28, 2019
Rollup of 15 pull requests Successful merges: - #65244 (add IntoFuture trait and support for await) - #67576 (reuse `capacity` variable in slice::repeat) - #67588 (Use NonNull in slice::Iter and slice::IterMut.) - #67594 (Update libc to 0.2.66) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67604 (Add Scalar::to_(u|i)16 methods) - #67617 (Remove `compiler_builtins_lib` documentation) - #67621 (Use the correct type for static qualifs) - #67629 (Remove redundant link texts) - #67632 (Convert collapsed to shortcut reference links) - #67633 (Update .mailmap) - #67635 (Document safety of Path casting) - #67654 (Add regression test for old NLL ICE) - #67659 (Stabilize the `matches!` macro) - #67664 (Fix some mailmap entries) Failed merges: r? @ghost
|
@christianpoveda can you submit a PR against Miri to use this function and remove the FIXME? |
|
sure |
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Dec 28, 2019
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Dec 28, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung