Skip to content

resolve: Minor cleanup of duplicate macro reexports #67677

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

petrochenkov
Copy link
Contributor

Enabled by #65785 which changed duplicate_macro_exports from a lint to a hard error.

@rust-highfive
Copy link
Contributor

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2019
@Centril
Copy link
Contributor

Centril commented Dec 28, 2019

Neat! r? @Centril @bors r+

@bors
Copy link
Collaborator

bors commented Dec 28, 2019

📌 Commit a0d8b79 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned zackmdavis Dec 28, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2019
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 29, 2019
resolve: Minor cleanup of duplicate macro reexports

Enabled by rust-lang#65785 which changed `duplicate_macro_exports` from a lint to a hard error.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 30, 2019
resolve: Minor cleanup of duplicate macro reexports

Enabled by rust-lang#65785 which changed `duplicate_macro_exports` from a lint to a hard error.
bors added a commit that referenced this pull request Dec 30, 2019
Rollup of 10 pull requests

Successful merges:

 - #64273 (Stabilize attribute macros on inline modules)
 - #67287 (typeck: note other end-point when checking range pats)
 - #67564 (docs: Iterator adapters have unspecified results after a panic)
 - #67622 (Some keyword documentation.)
 - #67657 (Clean up const-hack PRs now that const if / match exist.)
 - #67677 (resolve: Minor cleanup of duplicate macro reexports)
 - #67687 (Do not ICE on lifetime error involving closures)
 - #67698 (Move reachable_set and diagnostic_items to librustc_passes.)
 - #67701 (tidy: Enforce formatting rather than just check it if `--bless` is specified)
 - #67715 (Typo fix)

Failed merges:

r? @ghost
@bors bors merged commit a0d8b79 into rust-lang:master Dec 30, 2019
@petrochenkov petrochenkov deleted the dupexp branch February 22, 2025 18:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants