Implement uncommon_codepoints lint. #67810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Manishearth
approved these changes
Jan 2, 2020
crlf0710
force-pushed
the
uncommon_codepoints_lint
branch
from
3540478 to
549ac20
Compare
Centril
reviewed
Jan 2, 2020
crlf0710
force-pushed
the
uncommon_codepoints_lint
branch
from
549ac20 to
a204e81
Compare
|
@bors r+ roll-up=maybe |
|
📌 Commit a204e81 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=maybe dammit autocorrect |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 2, 2020
…r=Manishearth Implement uncommon_codepoints lint. Part of rust-lang#55467 . The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r- ^--- |
bors
added
S-waiting-on-author
crlf0710
force-pushed
the
uncommon_codepoints_lint
branch
from
a204e81 to
485e98a
Compare
|
One of the existing tests triggered this lint. I added |
|
@Manishearth @Centril I think @estebank will be away this week... Would you mind review this? |
|
@bors r+ |
|
📌 Commit 485e98a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 3, 2020
…r=Manishearth Implement uncommon_codepoints lint. Part of rust-lang#55467 . The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 4, 2020
…r=Manishearth Implement uncommon_codepoints lint. Part of rust-lang#55467 . The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
bors
added a commit
that referenced
this pull request
Jan 4, 2020
Rollup of 8 pull requests Successful merges: - #66913 (Suggest calling method when first argument is `self`) - #67531 (no longer promote non-pattern const functions) - #67773 (Add a test for #37333) - #67786 (Nix reexports from `rustc_span` in `syntax`) - #67789 (Cleanup linkchecker whitelist) - #67810 (Implement uncommon_codepoints lint.) - #67835 (tweak wording of mismatched delimiter errors) - #67845 (Also remove const-hack for abs) Failed merges: r? @ghost
23 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55467 . The checks of
$crateand{{root}}are very unfortunate. But i'm not sure where they belongs to.