Also remove const-hack for abs #67845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit ae002c1 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 3, 2020
…i-obk Also remove const-hack for abs Closes rust-lang#67842. r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 4, 2020
…i-obk Also remove const-hack for abs Closes rust-lang#67842. r? @oli-obk
bors
added a commit
that referenced
this pull request
Jan 4, 2020
Rollup of 8 pull requests Successful merges: - #66913 (Suggest calling method when first argument is `self`) - #67531 (no longer promote non-pattern const functions) - #67773 (Add a test for #37333) - #67786 (Nix reexports from `rustc_span` in `syntax`) - #67789 (Cleanup linkchecker whitelist) - #67810 (Implement uncommon_codepoints lint.) - #67835 (tweak wording of mismatched delimiter errors) - #67845 (Also remove const-hack for abs) Failed merges: r? @ghost
petrochenkov
reviewed
Jan 4, 2020
|
@bors r+ |
|
📌 Commit cc2044641d59b81f17fbff9934da769066208a7d has been approved by |
|
@jumbatm Why was this PR closed? It seems that while the first commit was merged in the "Rollup of 8 pull requests", the second commit was not merged. |
|
Ah, I see. It closed when I pushed a delete branch to my fork, sorry! |
|
@oli-obk Does this PR need to be reopened and r+ed once again? |
|
Please rebase over master so we see what is unmerged so far |
jumbatm
force-pushed
the
also-unconst-hack-abs
branch
from
cc20446 to
525cd2d
Compare
|
Done |
|
@bors r+ rollup |
|
📌 Commit 525cd2d has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 5, 2020
…i-obk Also remove const-hack for abs Closes rust-lang#67842. r? @oli-obk
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 5, 2020
…i-obk Also remove const-hack for abs Closes rust-lang#67842. r? @oli-obk
bors
added a commit
that referenced
this pull request
Jan 5, 2020
Rollup of 5 pull requests Successful merges: - #67818 (rustdoc: Avoid panic when parsing codeblocks for playground links) - #67845 (Also remove const-hack for abs) - #67879 (Remove negative number check from float sqrt) - #67881 (Add backticks to various diagnostics) - #67882 (remove bespoke flock bindings) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67842.
r? @oli-obk