Skip to content

Rollup of 4 pull requests #68768

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 9 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 2, 2020

Successful merges:

Failed merges:

r? @ghost

astrolemonade and others added 9 commits February 1, 2020 19:05
I updated the example of the `expect` examples so they won't contain depressing sentences any more !
Update option.rs

I updated the example of the `expect` examples so they won't contain depressing sentences any more !
Issue error on `compile-fail` header in UI test

Fixes rust-lang#68732

r? @Centril
parser: syntactically allow `self` in all `fn` contexts

Part of rust-lang#68728.

`self` parameters are now *syntactically* allowed as the first parameter irrespective of item context (and in function pointers). Instead, semantic validation (`ast_validation`) is used.

r? @petrochenkov
@Centril
Copy link
Contributor Author

Centril commented Feb 2, 2020

@bors r+ p=4 rollup=never

@bors
Copy link
Collaborator

bors commented Feb 2, 2020

📌 Commit 66a06f3 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 2, 2020
@bors
Copy link
Collaborator

bors commented Feb 2, 2020

⌛ Testing commit 66a06f3 with merge ea7fd59cd1345b2f8f071e08378bf3f597cada13...

@Centril
Copy link
Contributor Author

Centril commented Feb 2, 2020

Enlarging, @bors retry r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2020
@Centril Centril closed this Feb 2, 2020
@Centril Centril deleted the rollup-2g98up8 branch February 2, 2020 13:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants