Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix more clippy findings #69802

Merged
merged 12 commits into from
Mar 13, 2020
Merged

fix more clippy findings #69802

merged 12 commits into from
Mar 13, 2020

Conversation

matthiaskrgr
Copy link
Member

  • reduce references on match patterns (clippy::match_ref_pats)
  • Use writeln!(fmt, "word") instead of write!(fmt, "word\n") (clippy::write_with_newline)
  • libtest: remove redundant argument to writeln!() (clippy::writeln_empty_string)
  • remove unneeded mutable references (cippy::unnecessary_mut_passed)
  • libtest: declare variables as floats instead of casting them (clippy::unnecessary_cast)
  • rustdoc: remove redundant static lifetimes (clippy::redundant_static_lifetimes)
  • call .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref)
  • iterate over a maps values directly. (clippy::for_kv_map)
  • rustdoc: simplify boolean condition (clippy::nonminimal_bool)
  • Use ?-operator in more places (clippy::question_mark, had some false negatives fixed recently)
  • rustdoc: Use .any(p) instead of find(p).is_some(). (clippy::search_is_some)
  • rustdoc: don't call into_iter() on iterator. (clippy::identity_conversion)

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2020
@matthiaskrgr
rustdoc: don't call into_iter() on iterator. (clippy::identity_conver…
9fa7981 
…sion)
@matthiaskrgr
rustdoc: Use .any(p) instead of find(p).is_some(). (clippy::search_is…
6bfff8a 
…_some)
@matthiaskrgr
Use ?-operator in more places (clippy::question_mark, had some false …
7aad89a 
…negatives fixed recently)
@matthiaskrgr
rustdoc: simplify boolean condition (clippy::nonminimal_bool)
45108b1
@matthiaskrgr
iterate over a maps values directly. (clippy::for_kv_map)
1351db3
@matthiaskrgr
call .as_deref() instead of .as_ref().map(Deref::deref) (clippy::opti…
254ceae 
…on_as_ref_deref)
@matthiaskrgr
rustdoc: remove redundant static lifetimes (clippy::redundant_static_…
0d7faaf 
…lifetimes)
@matthiaskrgr
libtest: declare variables as floats instead of casting them (clippy:…
cca3d52 
…:unnecessary_cast)
@matthiaskrgr
remove unneeded mutable references (cippy::unnecessary_mut_passed)
77af19e
@matthiaskrgr
libtest: remove redundant argument to writeln!() (clippy::writeln_emp…
f326f0f 
…ty_string)
@matthiaskrgr
Use writeln!(fmt, "word") instead of write!(fmt, "word\n") (clippy::w…
3f87f8c 
…rite_with_newline)
@matthiaskrgr
reduce references on match patterns (clippy::match_ref_pats)
8351138
@matthiaskrgr
Copy link
Member Author

r? @GuillaumeGomez

@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Mar 11, 2020

📌 Commit 8351138 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 12, 2020
@Centril
Rollup merge of rust-lang#69802 - matthiaskrgr:cl1ppy, r=Dylan-DPC
1185d8b 
fix more clippy findings

* reduce references on match patterns (clippy::match_ref_pats)
* Use writeln!(fmt, "word") instead of write!(fmt, "word\n") (clippy::write_with_newline)
* libtest: remove redundant argument to writeln!() (clippy::writeln_empty_string)
* remove unneeded mutable references (cippy::unnecessary_mut_passed)
* libtest: declare variables as floats instead of casting them (clippy::unnecessary_cast)
* rustdoc: remove redundant static lifetimes (clippy::redundant_static_lifetimes)
* call .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref)
* iterate over a maps values directly. (clippy::for_kv_map)
* rustdoc: simplify boolean condition (clippy::nonminimal_bool)
* Use ?-operator in more places (clippy::question_mark, had some false negatives fixed recently)
* rustdoc: Use .any(p) instead of find(p).is_some(). (clippy::search_is_some)
* rustdoc: don't call into_iter() on iterator. (clippy::identity_conversion)
@Centril Centril mentioned this pull request Mar 12, 2020
Closed
bors added a commit that referenced this pull request Mar 13, 2020
@bors
Auto merge of #69958 - Centril:rollup-ecgx11p, r=Centril
9757e90 
Rollup of 8 pull requests

Successful merges:

 - #68746 (Make macro metavars respect (non-)hygiene)
 - #69189 (Erase regions in writeback)
 - #69402 (Extend search)
 - #69403 (Implement `Copy` for `IoSlice`)
 - #69460 (Move some `build-pass` tests to `check-pass`)
 - #69802 (fix more clippy findings)
 - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes))
 - #69949 (triagebot.toml: add ping aliases)

Failed merges:

 - #69589 (ast: `Mac`/`Macro` -> `MacCall`)

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2020
@Centril
Rollup merge of rust-lang#69802 - matthiaskrgr:cl1ppy, r=Dylan-DPC
881b87b 
fix more clippy findings

* reduce references on match patterns (clippy::match_ref_pats)
* Use writeln!(fmt, "word") instead of write!(fmt, "word\n") (clippy::write_with_newline)
* libtest: remove redundant argument to writeln!() (clippy::writeln_empty_string)
* remove unneeded mutable references (cippy::unnecessary_mut_passed)
* libtest: declare variables as floats instead of casting them (clippy::unnecessary_cast)
* rustdoc: remove redundant static lifetimes (clippy::redundant_static_lifetimes)
* call .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref)
* iterate over a maps values directly. (clippy::for_kv_map)
* rustdoc: simplify boolean condition (clippy::nonminimal_bool)
* Use ?-operator in more places (clippy::question_mark, had some false negatives fixed recently)
* rustdoc: Use .any(p) instead of find(p).is_some(). (clippy::search_is_some)
* rustdoc: don't call into_iter() on iterator. (clippy::identity_conversion)
@Centril Centril mentioned this pull request Mar 13, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Mar 13, 2020
Merged
bors added a commit that referenced this pull request Mar 13, 2020
@bors
Auto merge of #69986 - JohnTitor:rollup-h0809mf, r=JohnTitor
1572c43 
Rollup of 12 pull requests

Successful merges:

 - #69403 (Implement `Copy` for `IoSlice`)
 - #69460 (Move some `build-pass` tests to `check-pass`)
 - #69723 (Added doc on keyword Pub.)
 - #69802 (fix more clippy findings)
 - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes))
 - #69947 (Clean up E0423 explanation)
 - #69949 (triagebot.toml: add ping aliases)
 - #69954 (rename panic_if_ intrinsics to assert_)
 - #69960 (miri engine: fix treatment of abort intrinsic)
 - #69966 (Add more regression tests)
 - #69973 (Update stable-since version for const_int_conversion)
 - #69974 (Clean up E0434 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 8e17c83 into rust-lang:master Mar 13, 2020
@matthiaskrgr matthiaskrgr deleted the cl1ppy branch January 25, 2025 09:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ollie27 ollie27 ollie27 left review comments

@tesuji tesuji tesuji left review comments

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@matthiaskrgr @Dylan-DPC-zz @bors @ollie27 @tesuji @GuillaumeGomez @QuietMisdreavus @JohnTitor