Rollup of 12 pull requests #69986
Merged
Rollup of 12 pull requests #69986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…negatives fixed recently)
…:unnecessary_cast)
…rite_with_newline)
…ckler Implement `Copy` for `IoSlice` Resolves rust-lang#69395 r? @sfackler
…r=RalfJung Move some `build-pass` tests to `check-pass` Helps with rust-lang#62277. r? @cramertj cc @Centril
…acrum Added doc on keyword Pub. Hi, this is my first pull request. I hope it's OK. Please let me know if it would benefit from any changes. Thank you.
fix more clippy findings * reduce references on match patterns (clippy::match_ref_pats) * Use writeln!(fmt, "word") instead of write!(fmt, "word\n") (clippy::write_with_newline) * libtest: remove redundant argument to writeln!() (clippy::writeln_empty_string) * remove unneeded mutable references (cippy::unnecessary_mut_passed) * libtest: declare variables as floats instead of casting them (clippy::unnecessary_cast) * rustdoc: remove redundant static lifetimes (clippy::redundant_static_lifetimes) * call .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref) * iterate over a maps values directly. (clippy::for_kv_map) * rustdoc: simplify boolean condition (clippy::nonminimal_bool) * Use ?-operator in more places (clippy::question_mark, had some false negatives fixed recently) * rustdoc: Use .any(p) instead of find(p).is_some(). (clippy::search_is_some) * rustdoc: don't call into_iter() on iterator. (clippy::identity_conversion)
remove lifetimes that can be elided (clippy::needless_lifetimes)
…an-DPC Clean up E0423 explanation r? @Dylan-DPC
…ark-Simulacrum triagebot.toml: add ping aliases I think I got the syntax right. Closes rust-lang/triagebot#402. r? @Mark-Simulacrum cc @pnkfelix
…,eddyb rename panic_if_ intrinsics to assert_ [Suggested by @eddyb](rust-lang/miri#1222 (comment))
miri engine: fix treatment of abort intrinsic I screwed up in rust-lang#69830 and added `abort` to the wrong block of intrinsics, namely the one that actually has a return place. So that branch was never actually reached. r? @oli-obk
Add more regression tests Closes rust-lang#58490, closes rust-lang#60390, closes rust-lang#62504, closes rust-lang#67739, closes rust-lang#69092 r? @Centril
…, r=dtolnay Update stable-since version for const_int_conversion Since rust-lang#69373 was not merged in time for 1.43.0 beta, update to `since = "1.44.0"`.
…an-DPC Clean up E0434 explanation r? @Dylan-DPC
|
@bors r+ rollup=never p=12 |
|
📌 Commit 1d8f5f0 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
This was referenced Mar 13, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
CopyforIoSlice#69403 (ImplementCopyforIoSlice)build-passtests tocheck-pass#69460 (Move somebuild-passtests tocheck-pass)Failed merges:
r? @ghost