-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix diagnostics for @ ..
binding pattern in tuples and tuple structs
#72677
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Modified the suggestion slightly to better address attempts to define a e.g.,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks, let me know what you think.
Thanks Esteban! I committed the two new suggestions and will push updated test files. |
Tests updated with the latest round of changes in dbb2d6b |
@estebank I'll wait for this to pass the CI tests and then will squash. Let me know if you feel that any other changes are needed. This looks good 👍
|
fix comment add newline for tidy fmt error... edit suggestion message change the suggestion message to better handle cases with binding modes Apply suggestions from estebank code review Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com> edits to address source review Apply suggestions from estebank code review rust-lang#2 Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com> update test files
Squashed to 27ed143 All set on my end. Please let me know if there is anything else that I need to address. Thanks again Esteban. |
@bors r+ rollup |
📌 Commit 27ed143 has been approved by |
Rollup of 10 pull requests Successful merges: - rust-lang#72033 (Update RELEASES.md for 1.44.0) - rust-lang#72162 (Add Extend::{extend_one,extend_reserve}) - rust-lang#72419 (Miri read_discriminant: return a scalar instead of raw underlying bytes) - rust-lang#72621 (Don't bail out of trait selection when predicate references an error) - rust-lang#72677 (Fix diagnostics for `@ ..` binding pattern in tuples and tuple structs) - rust-lang#72710 (Add test to make sure -Wunused-crate-dependencies works with tests) - rust-lang#72724 (Revert recursive `TokenKind::Interpolated` expansion for now) - rust-lang#72741 (Remove unused mut from long-linker-command-lines test) - rust-lang#72750 (Remove remaining calls to `as_local_node_id`) - rust-lang#72752 (remove mk_bool) Failed merges: r? @ghost
Fixes #72574
Associated #72534 #72373
Includes a new suggestion with
Applicability::MaybeIncorrect
confidence level.Before
tuple
tuple struct
After
Note: final output edited during source review discussion, see thread for details
tuple
tuple struct
r? @estebank