Skip to content

remove trivial mk_predicates #72754

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

remove trivial mk_predicates #72754

merged 1 commit into from
Jun 4, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 29, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2020
@jonas-schievink
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented May 29, 2020

⌛ Trying commit 8f8cb71 with merge 6f2a25b9e6a4b45c8348788283a52aa5c1f25e08...

@lcnr
Copy link
Contributor Author

lcnr commented May 29, 2020

Note to self: we probably should do the same for ty::Const if the benchmarks are positive.

@bors
Copy link
Collaborator

bors commented May 29, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2020
@nikomatsakis
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented May 30, 2020

⌛ Trying commit 8f8cb71 with merge 42aefaa7809e4b649b976e74548e1c8a43b24288...

@nikomatsakis
Copy link
Contributor

@bors rollup=never

@nikomatsakis
Copy link
Contributor

r=me pending perf results, though we should prob merge either way

@bors
Copy link
Collaborator

bors commented May 30, 2020

☀️ Try build successful - checks-azure
Build commit: 42aefaa7809e4b649b976e74548e1c8a43b24288 (42aefaa7809e4b649b976e74548e1c8a43b24288)

@rust-timer
Copy link
Collaborator

Queued 42aefaa7809e4b649b976e74548e1c8a43b24288 with parent 4bd32c9, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 42aefaa7809e4b649b976e74548e1c8a43b24288, comparison URL.

@jonas-schievink
Copy link
Contributor

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented May 30, 2020

📌 Commit 8f8cb71 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2020
@lcnr lcnr mentioned this pull request May 31, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 1, 2020
@Dylan-DPC
Rollup merge of rust-lang#72822 - lcnr:intern-me, r=estebank
79e0055 
remove trivial calls to mk_const

similar to rust-lang#72754
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 2, 2020
@JohnTitor
Rollup merge of rust-lang#72822 - lcnr:intern-me, r=estebank
f1732f6 
remove trivial calls to mk_const

similar to rust-lang#72754
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Collaborator

bors commented Jun 3, 2020

⌛ Testing commit 8f8cb71 with merge 8540bb61f82d4db4e7546f8515c009d1edd85638...

@Dylan-DPC-zz
Copy link

@bors retry yield

@bors
Copy link
Collaborator

bors commented Jun 3, 2020

⌛ Testing commit 8f8cb71 with merge ce9fb92624357e71a59afad6a156c415c8ea55b2...

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 3, 2020
@Dylan-DPC
Rollup merge of rust-lang#72754 - lcnr:predicate-fold, r=nikomatsakis
f14c1d4 
remove trivial `mk_predicate`s

r? @nikomatsakis
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 3, 2020
Closed
@Dylan-DPC-zz
Copy link

@bors retry yield

@bors
Copy link
Collaborator

bors commented Jun 3, 2020

⌛ Testing commit 8f8cb71 with merge f3fadf6...

@bors
Copy link
Collaborator

bors commented Jun 4, 2020

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing f3fadf6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 4, 2020
@bors bors merged commit f3fadf6 into rust-lang:master Jun 4, 2020
@lcnr lcnr deleted the predicate-fold branch June 4, 2020 05:50
@jonas-schievink jonas-schievink added relnotes-perf Performance improvements that should be mentioned in the release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2020
@jonas-schievink jonas-schievink added this to the 1.46 milestone Jun 22, 2020
@jyn514 jyn514 mentioned this pull request Feb 16, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. relnotes-perf Performance improvements that should be mentioned in the release notes. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @jonas-schievink @rust-timer @bors @nikomatsakis @Dylan-DPC-zz @rust-highfive