Skip to content

remove trivial calls to mk_const #72822

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

remove trivial calls to mk_const #72822

merged 1 commit into from
Jun 2, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 31, 2020

similar to #72754

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2020
@jonas-schievink
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented May 31, 2020

⌛ Trying commit 9f83d36 with merge f8f8439f19254c02ff2725f68301a5c10809bffc...

@estebank
Copy link
Contributor

r=me if perf is green

@bors
Copy link
Collaborator

bors commented May 31, 2020

☀️ Try build successful - checks-azure
Build commit: f8f8439f19254c02ff2725f68301a5c10809bffc (f8f8439f19254c02ff2725f68301a5c10809bffc)

@rust-timer
Copy link
Collaborator

Queued f8f8439f19254c02ff2725f68301a5c10809bffc with parent 4b1f86a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit f8f8439f19254c02ff2725f68301a5c10809bffc, comparison URL.

@bjorn3
Copy link
Member

bjorn3 commented Jun 1, 2020

This is a slight improvement. (~0.1%)

@estebank
Copy link
Contributor

estebank commented Jun 1, 2020

@bors r+

It seems within noise levels, but I could also see it being relevant to very const heavy code that doesn't exist (and we don't test for) yet. Allowing this to be a rollup merge.

@bors
Copy link
Collaborator

bors commented Jun 1, 2020

📌 Commit 9f83d36 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 1, 2020
@Dylan-DPC
Rollup merge of rust-lang#72822 - lcnr:intern-me, r=estebank
79e0055 
remove trivial calls to mk_const

similar to rust-lang#72754
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 1, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Jun 2, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2020
@bors
Auto merge of rust-lang#72905 - JohnTitor:rollup-phtyo5i, r=JohnTitor
10c2316 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#72775 (Return early to avoid ICE)
 - rust-lang#72795 (Add a test for `$:ident` in proc macro input)
 - rust-lang#72822 (remove trivial calls to mk_const)
 - rust-lang#72825 (Clarify errors and warnings about the transition to the new asm!)
 - rust-lang#72827 (changed *nix to Unix-like)
 - rust-lang#72880 (Clean up E0637 explanation)
 - rust-lang#72886 (Remove allow missing_debug_implementations for MaybeUninit)
 - rust-lang#72889 (rustc: Remove the `--passive-segments` LLD flag on wasm)
 - rust-lang#72891 (Add associated consts MIN/MAX for Wrapping<Int>)
 - rust-lang#72893 (test miri-unleash TLS accesses)

Failed merges:

r? @ghost
@bors bors merged commit f1732f6 into rust-lang:master Jun 2, 2020
@lcnr lcnr deleted the intern-me branch June 2, 2020 07:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @rust-highfive @jonas-schievink @rust-timer @bors @estebank @bjorn3