-
Notifications
You must be signed in to change notification settings - Fork 13.4k
remove trivial calls to mk_const #72822
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 9f83d36 with merge f8f8439f19254c02ff2725f68301a5c10809bffc... |
r=me if perf is green |
☀️ Try build successful - checks-azure |
Queued f8f8439f19254c02ff2725f68301a5c10809bffc with parent 4b1f86a, future comparison URL. |
Finished benchmarking try commit f8f8439f19254c02ff2725f68301a5c10809bffc, comparison URL. |
This is a slight improvement. (~0.1%) |
@bors r+ It seems within noise levels, but I could also see it being relevant to very |
📌 Commit 9f83d36 has been approved by |
remove trivial calls to mk_const similar to rust-lang#72754
Rollup of 10 pull requests Successful merges: - rust-lang#72775 (Return early to avoid ICE) - rust-lang#72795 (Add a test for `$:ident` in proc macro input) - rust-lang#72822 (remove trivial calls to mk_const) - rust-lang#72825 (Clarify errors and warnings about the transition to the new asm!) - rust-lang#72827 (changed *nix to Unix-like) - rust-lang#72880 (Clean up E0637 explanation) - rust-lang#72886 (Remove allow missing_debug_implementations for MaybeUninit) - rust-lang#72889 (rustc: Remove the `--passive-segments` LLD flag on wasm) - rust-lang#72891 (Add associated consts MIN/MAX for Wrapping<Int>) - rust-lang#72893 (test miri-unleash TLS accesses) Failed merges: r? @ghost
similar to #72754