Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enforce doc alias check #72780

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

GuillaumeGomez
Copy link
Member

Part of #50146.

r? @ollie27

@crlf0710 crlf0710 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2020
@GuillaumeGomez
Copy link
Member Author

ping @ollie27

cc @rust-lang/rustdoc

@ollie27
Copy link
Member

ollie27 commented Jun 20, 2020

Sorry for the delay. This is a good start. There's a lot more validation to do and it should probably be done inside rustc but for now let's get this merged at least for the test.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 20, 2020

📌 Commit 2d6267a has been approved by ollie27

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 23, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 23, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 23, 2020
…arth

Rollup of 11 pull requests

Successful merges:

 - rust-lang#72780 (Enforce doc alias check)
 - rust-lang#72876 (Mention that BTreeMap::new() doesn't allocate)
 - rust-lang#73244 (Check for assignments between non-conflicting generator saved locals)
 - rust-lang#73488 (code coverage foundation for hash and num_counters)
 - rust-lang#73523 (Fix -Z unpretty=everybody_loops)
 - rust-lang#73587 (Move remaining `NodeId` APIs from `Definitions` to `Resolver`)
 - rust-lang#73601 (Point at the call span when overflow occurs during monomorphization)
 - rust-lang#73613 (The const propagator cannot trace references.)
 - rust-lang#73614 (fix `intrinsics::needs_drop` docs)
 - rust-lang#73630 (Provide context on E0308 involving fn items)
 - rust-lang#73665 (rustc: Modernize wasm checks for atomics)

Failed merges:

r? @ghost
@bors bors merged commit 7d2fba1 into rust-lang:master Jun 24, 2020
@GuillaumeGomez GuillaumeGomez deleted the enforce-doc-alias-check branch June 25, 2020 11:24
ratmice added a commit to ratmice/selinux that referenced this pull request Sep 21, 2021
"error: doc alias attribute expects a string: #[doc(alias = "a")]"
This error can be seen in the tests at
rust-lang/rust#72780
ratmice added a commit to ratmice/selinux that referenced this pull request Sep 21, 2021
"error: doc alias attribute expects a string: #[doc(alias = "a")]"
This error can be seen in the tests at
rust-lang/rust#72780
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants