run-make regression test for issue #70924. #72952

pnkfelix · 2020-06-03T18:32:28Z

Sometime after my PR #72767 (to fix issue #70924) landed, I realized that I could make a local regression test, thanks to rustc --print sysroot: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.

rust-highfive · 2020-06-03T18:32:30Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

pnkfelix · 2020-06-04T12:55:59Z

(okay it looks like this test won't break the windows build. I'll remove the test commit pnkfelix@56d185f now )

nikomatsakis · 2020-06-04T22:51:59Z

@bors r+ rollup

bors · 2020-06-04T22:52:01Z

📌 Commit 94605b9 has been approved by nikomatsakis

…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.

mati865 · 2020-06-05T10:42:49Z

Failed in rollup: https://dev.azure.com/rust-lang/rust/_build/results?buildId=31133&view=logs&j=a6a2dd6f-5140-5fa9-b933-dfe57be2bdd5&t=53c32ceb-c4c2-54e8-ee5b-d47a390af72f

make[1]: Entering directory '/d/a/1/s/src/test/run-make-fulldeps/incr-add-rust-src-component'
mkdir /d/a/1/s/build/x86_64-pc-windows-msvc/test/run-make-fulldeps/incr-add-rust-src-component/incr-add-rust-src-component/fakeroot
ln -s C:\MORE_SPACE\x86_64-pc-windows-msvc\stage2/* /d/a/1/s/build/x86_64-pc-windows-msvc/test/run-make-fulldeps/incr-add-rust-src-component/incr-add-rust-src-component/fakeroot
make[1]: Leaving directory '/d/a/1/s/src/test/run-make-fulldeps/incr-add-rust-src-component'

------------------------------------------
stderr:
------------------------------------------
ln: failed to create symbolic link '/d/a/1/s/build/x86_64-pc-windows-msvc/test/run-make-fulldeps/incr-add-rust-src-component/incr-add-rust-src-component/fakeroot/*': No such file or directory
make[1]: *** [Makefile:25: all] Error 1

Dylan-DPC-zz · 2020-06-05T11:02:19Z

@bors r-

pnkfelix · 2020-06-05T14:04:48Z

argh, I specifically thought I tested windows-msvc in pnkfelix@56d185f

I'll see what I can do about making this test only run on compatible platforms. And also check with the infrastructure team about what I did wrong in my attempt to do a test run.

pnkfelix · 2020-06-05T16:12:40Z

@bors r=nikomatsakis rollup

bors · 2020-06-05T16:12:41Z

📌 Commit a9d5dff has been approved by nikomatsakis

pnkfelix · 2020-06-05T16:27:52Z

argh, I specifically thought I tested windows-msvc in pnkfelix@56d185f

I'll see what I can do about making this test only run on compatible platforms. And also check with the infrastructure team about what I did wrong in my attempt to do a test run.

(the answer to what I did wrong: I added my test commit, but I never actually asked bors to do a try run! 🤦)

…70924, r=nikomatsakis run-make regression test for issue rust-lang#70924. Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.

RalfJung · 2020-06-06T20:04:45Z

This is one of only a few PRs that are in the intersection of 4 rollups that all failed the same way: #72952, #72977, #73007.

The failure is on 32bit Windows, a bunch of tests show

------------------------------------------
stderr:
------------------------------------------
thread 'rustc' panicked at 'assertion failed: self.ptr <= self.end', D:\a\1\s\src\libstd\macros.rs:13:23
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The line number is utterly useless, it points to the macro definition (how is that possible?!?).

Affected tests:

failures:
    [ui] ui\fn\expr-fn-panic.rs
    [ui] ui\imports\glob-use-std.rs
    [ui] ui\macros\die-macro-2.rs
    [ui] ui\macros\die-macro-pure.rs
    [ui] ui\macros\unimplemented-macro-panic.rs
    [ui] ui\macros\unreachable-macro-panic.rs
    [ui] ui\macros\unreachable.rs
    [ui] ui\meta-revision-ok.rs#bar
    [ui] ui\meta-revision-ok.rs#foo
    [ui] ui\mir\mir_codegen_calls_diverging.rs
    [ui] ui\panics\doublepanic.rs
    [ui] ui\panics\explicit-panic.rs
    [ui] ui\panics\main-panic.rs
    [ui] ui\panics\panic-macro-explicit.rs
    [ui] ui\panics\panic-macro-owned.rs
    [ui] ui\panics\panic-macro-static.rs
    [ui] ui\panics\panic-main.rs
    [ui] ui\rfc-1937-termination-trait\termination-trait-for-never.rs

All 3 PRs in the intersection seem impossible to be the cause here, so I'd appreciate help with figuring out what is going on.^^

Dylan-DPC-zz · 2020-06-07T15:59:42Z

I am going to put 2 of them in a rollup so we can bisect (or trisect) which PR is causing the failure

Dylan-DPC-zz · 2020-06-07T16:09:53Z

@bors rollup=maybe

@ghost

Rollup of 2 pull requests Successful merges: - rust-lang#72952 (run-make regression test for issue rust-lang#70924.) - rust-lang#72977 (Fix codegen tests for RISC-V) Failed merges: r? @ghost

…-component, r=wesleywiser Migrate `incr-add-rust-src-component` to rmake This PR partially supersedes rust-lang#128562, and ports the Makefile-based `tests/run-make/incr-add-rust-src-component` to use rmake.rs infra. Part of rust-lang#121876. This run-make test is a regression test for rust-lang#70924. It (tries to) checks that if we add the `rust-src` component in between two incremental compiles, that the compiler doesn't ICE on the second invocation. - Original issue:rust-lang#70924 - Fix PR: rust-lang#72767 - PR adding this regression test: rust-lang#72952 However, the Makefile version of this used `$SYSROOT/lib/rustlib/src/rust/src/libstd/lib.rs`, but that actually got moved around and reorganized over the years. As of Dec 2024, the `rust-src` component is more like (specific for our purposes): ``` $SYSROOT/lib/rustlib/src/rust/ library/std/src/lib.rs src/ ``` However, this run-make test is ancient and it exercises incr-comp system logic. I'm not sure if this test would actually catch the original regression. This PR was co-authored with `@Oneirical.` r? incremental try-job: i686-msvc try-job: x86_64-mingw-1 try-job: x86_64-msvc try-job: aarch64-apple

Rollup merge of rust-lang#134656 - jieyouxu:migrate-incr-add-rust-src-component, r=wesleywiser Migrate `incr-add-rust-src-component` to rmake This PR partially supersedes rust-lang#128562, and ports the Makefile-based `tests/run-make/incr-add-rust-src-component` to use rmake.rs infra. Part of rust-lang#121876. This run-make test is a regression test for rust-lang#70924. It (tries to) checks that if we add the `rust-src` component in between two incremental compiles, that the compiler doesn't ICE on the second invocation. - Original issue:rust-lang#70924 - Fix PR: rust-lang#72767 - PR adding this regression test: rust-lang#72952 However, the Makefile version of this used `$SYSROOT/lib/rustlib/src/rust/src/libstd/lib.rs`, but that actually got moved around and reorganized over the years. As of Dec 2024, the `rust-src` component is more like (specific for our purposes): ``` $SYSROOT/lib/rustlib/src/rust/ library/std/src/lib.rs src/ ``` However, this run-make test is ancient and it exercises incr-comp system logic. I'm not sure if this test would actually catch the original regression. This PR was co-authored with `@Oneirical.` r? incremental try-job: i686-msvc try-job: x86_64-mingw-1 try-job: x86_64-msvc try-job: aarch64-apple

…-component, r=wesleywiser Migrate `incr-add-rust-src-component` to rmake This PR partially supersedes rust-lang#128562, and ports the Makefile-based `tests/run-make/incr-add-rust-src-component` to use rmake.rs infra. Part of rust-lang#121876. This run-make test is a regression test for rust-lang#70924. It (tries to) checks that if we add the `rust-src` component in between two incremental compiles, that the compiler doesn't ICE on the second invocation. - Original issue:rust-lang#70924 - Fix PR: rust-lang#72767 - PR adding this regression test: rust-lang#72952 However, the Makefile version of this used `$SYSROOT/lib/rustlib/src/rust/src/libstd/lib.rs`, but that actually got moved around and reorganized over the years. As of Dec 2024, the `rust-src` component is more like (specific for our purposes): ``` $SYSROOT/lib/rustlib/src/rust/ library/std/src/lib.rs src/ ``` However, this run-make test is ancient and it exercises incr-comp system logic. I'm not sure if this test would actually catch the original regression. This PR was co-authored with `@Oneirical.` r? incremental try-job: i686-msvc try-job: x86_64-mingw-1 try-job: x86_64-msvc try-job: aarch64-apple

rust-highfive assigned nikomatsakis Jun 3, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2020

pnkfelix changed the title ~~run-make regression test for issue #70924.~~ [WIP] run-make regression test for issue #70924. Jun 3, 2020

run-make regression test for issue rust-lang#70924.

94605b9

pnkfelix force-pushed the regression-test-for-issue-70924 branch from 56d185f to 94605b9 Compare June 4, 2020 12:57

pnkfelix changed the title ~~[WIP] run-make regression test for issue #70924.~~ run-make regression test for issue #70924. Jun 4, 2020

pnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 4, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2020

Dylan-DPC-zz mentioned this pull request Jun 5, 2020

Rollup of 5 pull requests #73009

Closed

Dylan-DPC-zz mentioned this pull request Jun 5, 2020

Rollup of 5 pull requests #73018

Closed

mati865 mentioned this pull request Jun 5, 2020

Fix codegen tests for RISC-V #72977

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2020

Ignore windows in the test.

a9d5dff

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2020

Dylan-DPC-zz mentioned this pull request Jun 5, 2020

Rollup of 5 pull requests #73042

Closed

Dylan-DPC-zz mentioned this pull request Jun 5, 2020

Rollup of 5 pull requests #73043

Closed

Dylan-DPC-zz mentioned this pull request Jun 6, 2020

Rollup of 5 pull requests #73048

Closed

Dylan-DPC-zz mentioned this pull request Jun 6, 2020

Rollup of 5 pull requests #73049

Closed

RalfJung mentioned this pull request Jun 6, 2020

Rollup of 7 pull requests #73052

Closed

RalfJung mentioned this pull request Jun 6, 2020

Rollup of 7 pull requests #73053

Closed

RalfJung mentioned this pull request Jun 6, 2020

Rollup of 9 pull requests #73064

Closed

RalfJung mentioned this pull request Jun 6, 2020

impl ToSocketAddrs for (String, u16) #73007

Merged

Dylan-DPC-zz mentioned this pull request Jun 7, 2020

Rollup of 2 pull requests #73099

Merged

bors merged commit b733368 into rust-lang:master Jun 7, 2020

cbeuw mentioned this pull request Apr 21, 2021

Fix --remap-path-prefix not correctly remapping rust-src component paths and unify handling of path mapping with virtualized paths #83813

Merged

jieyouxu mentioned this pull request Dec 23, 2024

Migrate incr-add-rust-src-component to rmake #134656

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

run-make regression test for issue #70924. #72952

run-make regression test for issue #70924. #72952

Uh oh!

pnkfelix commented Jun 3, 2020 •

edited

Loading

Uh oh!

rust-highfive commented Jun 3, 2020

Uh oh!

pnkfelix commented Jun 4, 2020

Uh oh!

nikomatsakis commented Jun 4, 2020

Uh oh!

bors commented Jun 4, 2020

Uh oh!

mati865 commented Jun 5, 2020 •

edited

Loading

Uh oh!

Dylan-DPC-zz commented Jun 5, 2020

Uh oh!

pnkfelix commented Jun 5, 2020

Uh oh!

pnkfelix commented Jun 5, 2020

Uh oh!

bors commented Jun 5, 2020

Uh oh!

pnkfelix commented Jun 5, 2020

Uh oh!

RalfJung commented Jun 6, 2020

Uh oh!

Dylan-DPC-zz commented Jun 7, 2020

Uh oh!

Dylan-DPC-zz commented Jun 7, 2020

Uh oh!

Uh oh!

run-make regression test for issue #70924. #72952

run-make regression test for issue #70924. #72952

Uh oh!

Conversation

pnkfelix commented Jun 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 3, 2020

Uh oh!

pnkfelix commented Jun 4, 2020

Uh oh!

nikomatsakis commented Jun 4, 2020

Uh oh!

bors commented Jun 4, 2020

Uh oh!

mati865 commented Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dylan-DPC-zz commented Jun 5, 2020

Uh oh!

pnkfelix commented Jun 5, 2020

Uh oh!

pnkfelix commented Jun 5, 2020

Uh oh!

bors commented Jun 5, 2020

Uh oh!

pnkfelix commented Jun 5, 2020

Uh oh!

RalfJung commented Jun 6, 2020

Uh oh!

Dylan-DPC-zz commented Jun 7, 2020

Uh oh!

Dylan-DPC-zz commented Jun 7, 2020

Uh oh!

Uh oh!

pnkfelix commented Jun 3, 2020 •

edited

Loading

mati865 commented Jun 5, 2020 •

edited

Loading