-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add long error explanation for E0724 #73163
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add long error explanation for E0724 #73163
Conversation
Some changes occurred in diagnostic error codes |
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
r? @davidtwco |
6880338
to
0962af8
Compare
0962af8
to
e1f5248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few nits, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for resolving the comments - could you squash the GitHub suggestion commits. After that, r=me when CI passes.
Minor refactoring Minor refactoring Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Minor refactoring
aea0168
to
68b4c03
Compare
@bors r+ |
📌 Commit 68b4c03 has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#73033 (Fix #[thread_local] statics as asm! sym operands) - rust-lang#73036 (std: Enable atomic.fence emission on wasm32) - rust-lang#73163 (Add long error explanation for E0724) - rust-lang#73187 (Remove missed `cfg(bootstrap)`) - rust-lang#73195 (Provide suggestion to convert numeric op LHS rather than unwrapping RHS) - rust-lang#73247 (Add various Zulip notifications for prioritization) - rust-lang#73254 (Add comment about LocalDefId -> DefId) Failed merges: r? @ghost
Add long explanation for the E0724 error code
Part of #61137