Skip to content

Add comment about LocalDefId -> DefId #73254

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2020
Merged

Add comment about LocalDefId -> DefId #73254

merged 1 commit into from
Jun 12, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jun 11, 2020

Now there are instructions on how to convert back and forth on both
structs, not just one.

See also #73076

r? @lcnr

@jyn514
Add comment about LocalDefId -> DefId
1d8da94 
Now there are instructions on how to convert back and forth on both
structs, not just one.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2020
@lcnr
Copy link
Contributor

lcnr commented Jun 11, 2020

I don't remember ever getting r+ privileges.

But let's try it anyways
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2020

@lcnr: 🔑 Insufficient privileges: Not in reviewers

@jyn514
Copy link
Member Author

jyn514 commented Jun 11, 2020

r? @ecstatic-morse

@rust-highfive rust-highfive assigned ecstatic-morse and unassigned lcnr Jun 11, 2020
@Dylan-DPC-zz
Copy link

@bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2020

📌 Commit 1d8da94 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2020
@lcnr lcnr mentioned this pull request Jun 11, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 11, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2020
@bors
Auto merge of rust-lang#73259 - Dylan-DPC:rollup-m6nw1n0, r=Dylan-DPC
14027f3 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#73033 (Fix #[thread_local] statics as asm! sym operands)
 - rust-lang#73036 (std: Enable atomic.fence emission on wasm32)
 - rust-lang#73163 (Add long error explanation for E0724)
 - rust-lang#73187 (Remove missed `cfg(bootstrap)`)
 - rust-lang#73195 (Provide suggestion to convert numeric op LHS rather than unwrapping RHS)
 - rust-lang#73247 (Add various Zulip notifications for prioritization)
 - rust-lang#73254 (Add comment about LocalDefId -> DefId)

Failed merges:

r? @ghost
@bors bors merged commit 85a48d0 into rust-lang:master Jun 12, 2020
@jyn514 jyn514 deleted the local-def-id-comment branch June 12, 2020 01:32
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@ecstatic-morse ecstatic-morse

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
7 participants
@jyn514 @lcnr @bors @Dylan-DPC-zz @cuviper @rust-highfive @ecstatic-morse