Skip to content

adjust ub-enum test to be endianess-independent #73989

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 3, 2020

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2020
@RalfJung
Copy link
Member Author

RalfJung commented Jul 7, 2020

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned nikomatsakis Jul 7, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jul 7, 2020

@bors r+ rollup

if something other than zero should be tested, you can also use a repeating pattern like 0xAFAFAFAF, but in this case that's not necessary

@bors
Copy link
Collaborator

bors commented Jul 7, 2020

📌 Commit fb9fa5b has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2020
@bors
Copy link
Collaborator

bors commented Jul 7, 2020

⌛ Testing commit fb9fa5b with merge 5ff0b5fcd102aade4aa54ee7ac84546b0e72a16b...

@Manishearth
Copy link
Member

@bors retry yield

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 7, 2020
adjust ub-enum test to be endianess-independent

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 7, 2020
adjust ub-enum test to be endianess-independent

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.
@bors
Copy link
Collaborator

bors commented Jul 8, 2020

⌛ Testing commit fb9fa5b with merge 83402f628f85e9814949e3553eb96e27c0deb0ea...

@bors
Copy link
Collaborator

bors commented Jul 8, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 8, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jul 8, 2020

@bors retry

failed to fetch https://github.com/rust-lang/crates.io-index

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2020
@bors
Copy link
Collaborator

bors commented Jul 8, 2020

⌛ Testing commit fb9fa5b with merge 4a46f962bcd3d8bcebde95eea9661ace2aa3fa2c...

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020
adjust ub-enum test to be endianess-independent

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020
adjust ub-enum test to be endianess-independent

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020
adjust ub-enum test to be endianess-independent

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020
adjust ub-enum test to be endianess-independent

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 11, 2020
adjust ub-enum test to be endianess-independent

@cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 11, 2020
…arth

Rollup of 19 pull requests

Successful merges:

 - rust-lang#71322 (Accept tuple.0.0 as tuple indexing (take 2))
 - rust-lang#72303 (Add core::future::{poll_fn, PollFn})
 - rust-lang#73862 (Stabilize casts and coercions to `&[T]` in const fn)
 - rust-lang#73887 (stabilize const mem::forget)
 - rust-lang#73989 (adjust ub-enum test to be endianess-independent)
 - rust-lang#74045 (Explain effects of debugging options from config.toml)
 - rust-lang#74076 (Add `read_exact_at` and `write_all_at` to WASI's `FileExt`)
 - rust-lang#74099 (Add VecDeque::range* methods)
 - rust-lang#74100 (Use str::strip* in bootstrap)
 - rust-lang#74103 (Only add CFGuard on `windows-msvc` targets)
 - rust-lang#74109 (Only allow `repr(i128/u128)` on enum)
 - rust-lang#74122 (Start-up clean-up)
 - rust-lang#74125 (Correctly mark the ending span of a match arm)
 - rust-lang#74127 (Avoid "whitelist")
 - rust-lang#74129 (:arrow_up: rust-analyzer)
 - rust-lang#74135 (Update books)
 - rust-lang#74145 (Update rust-installer to latest version)
 - rust-lang#74161 (Fix  disabled dockerfiles)
 - rust-lang#74162 (take self by value in ToPredicate)

Failed merges:

r? @ghost
@bors bors merged commit ef3dc09 into rust-lang:master Jul 11, 2020
@RalfJung RalfJung deleted the ub-enum-test branch July 20, 2020 12:37
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants