Only allow `repr(i128/u128)` on enum #74109

nbdd0121 · 2020-07-06T20:06:07Z

Fixes #74082

rust-highfive · 2020-07-06T20:06:11Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2020-07-07T19:13:28Z

@bors r+ rollup

bors · 2020-07-07T19:13:29Z

📌 Commit 97867bb has been approved by petrochenkov

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

bors · 2020-07-08T09:33:57Z

⌛ Testing commit 97867bb with merge 3fc4f53ae69863d717002dc42380d4bba68c843b...

bors · 2020-07-08T09:39:34Z

💔 Test failed - checks-actions

Mark-Simulacrum · 2020-07-08T14:01:29Z

Tagging as relnotes -- this is technically a breaking change (cc @rust-lang/lang) but I think a reasonable one. I don't think we need to run crater on this PR, we can rely on the beta crater run to catch potential regressions.

petrochenkov · 2020-07-08T16:57:03Z

The failure looks spurious.
@bors retry

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

scottmcm · 2020-07-08T17:52:26Z

This seems like it's closing an obvious gap, so personally I'm fine with seeing it happen without an FCP.

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

joshtriplett · 2020-07-08T22:41:28Z

Seems reasonable to me.

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

@ghost

…arth Rollup of 19 pull requests Successful merges: - rust-lang#71322 (Accept tuple.0.0 as tuple indexing (take 2)) - rust-lang#72303 (Add core::future::{poll_fn, PollFn}) - rust-lang#73862 (Stabilize casts and coercions to `&[T]` in const fn) - rust-lang#73887 (stabilize const mem::forget) - rust-lang#73989 (adjust ub-enum test to be endianess-independent) - rust-lang#74045 (Explain effects of debugging options from config.toml) - rust-lang#74076 (Add `read_exact_at` and `write_all_at` to WASI's `FileExt`) - rust-lang#74099 (Add VecDeque::range* methods) - rust-lang#74100 (Use str::strip* in bootstrap) - rust-lang#74103 (Only add CFGuard on `windows-msvc` targets) - rust-lang#74109 (Only allow `repr(i128/u128)` on enum) - rust-lang#74122 (Start-up clean-up) - rust-lang#74125 (Correctly mark the ending span of a match arm) - rust-lang#74127 (Avoid "whitelist") - rust-lang#74129 (:arrow_up: rust-analyzer) - rust-lang#74135 (Update books) - rust-lang#74145 (Update rust-installer to latest version) - rust-lang#74161 (Fix disabled dockerfiles) - rust-lang#74162 (take self by value in ToPredicate) Failed merges: r? @ghost

according to various people on tech-pkg@, there are no problems with the Firefox build Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.][72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you cast a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.][72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

Pkgsrc changes: * Portability patches for Illumos have been intregrated upstream, so are no longer needed in pkgsrc. * Adjust one other patch, and update vendor/libc cargo checksum. Upstream changes: Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.] [72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you have a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.] [72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

nbdd0121 added 2 commits July 6, 2020 20:42

Only allow repr(i128/u128) on enum

5702e02

Add UI test for issue 74082

97867bb

rust-highfive assigned petrochenkov Jul 6, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2020

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 7, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

8cf88d5

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 7, 2020

Rollup of 7 pull requests #74138

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 8, 2020

Mark-Simulacrum added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 8, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2020

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

022259f

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 8, 2020

Rollup of 11 pull requests #74157

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

9220430

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 8, 2020

Rollup of 13 pull requests #74158

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

2f5639a

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

5fa4d01

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 10, 2020

Rollup of 13 pull requests #74205

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

9ff4ab5

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 10, 2020

Rollup of 13 pull requests #74206

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

b993139

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 10, 2020

Rollup of 13 pull requests #74208

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

1e238fb

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 10, 2020

Rollup of 17 pull requests #74223

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 11, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

733d3ac

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 11, 2020

Rollup of 19 pull requests #74229

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 11, 2020

Rollup merge of rust-lang#74109 - nbdd0121:issue-74082, r=petrochenkov

78f56b7

Only allow `repr(i128/u128)` on enum Fixes rust-lang#74082

Manishearth mentioned this pull request Jul 11, 2020

Rollup of 17 pull requests #74230

Closed

Manishearth mentioned this pull request Jul 11, 2020

Rollup of 19 pull requests #74235

Merged

bors merged commit 8efa197 into rust-lang:master Jul 11, 2020

nbdd0121 deleted the issue-74082 branch September 4, 2021 02:55

cuviper added this to the 1.46 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only allow `repr(i128/u128)` on enum #74109

Only allow `repr(i128/u128)` on enum #74109

Uh oh!

nbdd0121 commented Jul 6, 2020

Uh oh!

rust-highfive commented Jul 6, 2020

Uh oh!

petrochenkov commented Jul 7, 2020

Uh oh!

bors commented Jul 7, 2020

Uh oh!

bors commented Jul 8, 2020

Uh oh!

bors commented Jul 8, 2020

Uh oh!

Mark-Simulacrum commented Jul 8, 2020

Uh oh!

petrochenkov commented Jul 8, 2020

Uh oh!

scottmcm commented Jul 8, 2020 •

edited

Loading

Uh oh!

joshtriplett commented Jul 8, 2020

Uh oh!

Uh oh!

Only allow repr(i128/u128) on enum #74109

Only allow repr(i128/u128) on enum #74109

Uh oh!

Conversation

nbdd0121 commented Jul 6, 2020

Uh oh!

rust-highfive commented Jul 6, 2020

Uh oh!

petrochenkov commented Jul 7, 2020

Uh oh!

bors commented Jul 7, 2020

Uh oh!

bors commented Jul 8, 2020

Uh oh!

bors commented Jul 8, 2020

Uh oh!

Mark-Simulacrum commented Jul 8, 2020

Uh oh!

petrochenkov commented Jul 8, 2020

Uh oh!

scottmcm commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshtriplett commented Jul 8, 2020

Uh oh!

Uh oh!

Only allow `repr(i128/u128)` on enum #74109

Only allow `repr(i128/u128)` on enum #74109

scottmcm commented Jul 8, 2020 •

edited

Loading