Skip to content

Don't panic if the lhs of a div by zero is not statically known #74221

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

Don't panic if the lhs of a div by zero is not statically known #74221

merged 1 commit into from
Jul 16, 2020

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 10, 2020

Fixes #73993 for real this time

r? @wesleywiser

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2020
@wesleywiser
Copy link
Member

Thanks @oli-obk!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 12, 2020

📌 Commit f689839ab07b1575e355bf24dad2d35bbea99b68 has been approved by wesleywiser

@bors
Copy link
Collaborator

bors commented Jul 12, 2020

🌲 The tree is currently closed for pull requests below priority 30, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2020
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 12, 2020

@bors r=wesleywiser

I rebased, there was a weird CI failure about the issue I added, not sure what's up with that.

@bors
Copy link
Collaborator

bors commented Jul 12, 2020

📌 Commit d512a6c has been approved by wesleywiser

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#74221 - oli-obk:const_prop_ice, r=wesleywiser
350b9cf 
Don't panic if the lhs of a div by zero is not statically known

Fixes rust-lang#73993 for real this time

r? @wesleywiser
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#74221 - oli-obk:const_prop_ice, r=wesleywiser
03e6b82 
Don't panic if the lhs of a div by zero is not statically known

Fixes rust-lang#73993 for real this time

r? @wesleywiser
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#74221 - oli-obk:const_prop_ice, r=wesleywiser
dc676b9 
Don't panic if the lhs of a div by zero is not statically known

Fixes rust-lang#73993 for real this time

r? @wesleywiser
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
@Manishearth
Copy link
Member

@bors r-

#74306 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2020
@eddyb
Copy link
Member

eddyb commented Jul 13, 2020

@Manishearth this PR had already failed PR CI by the time the rollup was created, could we have bors gate on PR, and r- on failure?

@Manishearth
Copy link
Member

@eddyb cc @pietroalbini
we sometimes do have spurious failures though

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 14, 2020

Uhmm... are we running all tests twice on CI? https://dev.azure.com/rust-lang/rust/_build/results?buildId=34443&view=logs&j=698b0e4a-0480-533d-81fa-f38599aa328e&t=76a462a9-00ba-550c-bb03-47e063adb169&l=1000 already ran all tests and my test even passed, then later it failed when being run again with --emit metadata, which it shouldn't do, because I have // build-pass

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 14, 2020

I can now at least reproduce with --pass=check, but whyy

@wesleywiser
Copy link
Member

Is ConstProp not actually running in check mode or something?

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 14, 2020

The entire test should not be run in check mode. That's the whole point of // build-pass afaik.

Though... you're right in asking, why did I even add // build-pass. I just added it because otherwise the test didn't pass. looking at the log, it seems like it's indeed not being run at all. Yea, so running with --emit=metadata causes const prop to be ignored entirely.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 15, 2020
@wesleywiser
Copy link
Member

Looks like we just missed the beta train? #74323

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 15, 2020

oh well... The diff isn't big and I guess we can beta approve it tomorrow.

@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 15, 2020
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 16, 2020

@bors r=wesleywiser

@bors
Copy link
Collaborator

bors commented Jul 16, 2020

📌 Commit 703f680 has been approved by wesleywiser

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74221 - oli-obk:const_prop_ice, r=wesleywiser
0879a7f 
Don't panic if the lhs of a div by zero is not statically known

Fixes rust-lang#73993 for real this time

r? @wesleywiser
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74221 - oli-obk:const_prop_ice, r=wesleywiser
1ed0b41 
Don't panic if the lhs of a div by zero is not statically known

Fixes rust-lang#73993 for real this time

r? @wesleywiser
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74221 - oli-obk:const_prop_ice, r=wesleywiser
0a4036c 
Don't panic if the lhs of a div by zero is not statically known

Fixes rust-lang#73993 for real this time

r? @wesleywiser
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2020
@bors
Auto merge of rust-lang#74408 - Manishearth:rollup-9gxn4od, r=Manishe…
5c9e5df 
…arth

Rollup of 21 pull requests

Successful merges:

 - rust-lang#73566 (Don't run `everybody_loops` for rustdoc; instead ignore resolution errors)
 - rust-lang#73771 (Don't pollute docs/suggestions with libstd deps)
 - rust-lang#73794 (Small cleanup for E0705 explanation)
 - rust-lang#73807 (rustdoc: glue tokens before highlighting)
 - rust-lang#73835 (Clean up E0710 explanation)
 - rust-lang#73926 (Ignoring test case: [codegen] repr-transparent-aggregates-1.rs for aarch64)
 - rust-lang#73981 (Remove some `ignore-stage1` annotations.)
 - rust-lang#73998 (add regression test for rust-lang#61216)
 - rust-lang#74140 (Make hir ProjectionKind more precise)
 - rust-lang#74148 (Move #[doc(alias)] check in rustc)
 - rust-lang#74159 (forbid generic params in the type of const params)
 - rust-lang#74171 (Fix 44056 test with debug on macos.)
 - rust-lang#74221 (Don't panic if the lhs of a div by zero is not statically known)
 - rust-lang#74325 (Focus on the current file in the source file sidebar)
 - rust-lang#74359 (rustdoc: Rename internal API fns to `into_string`)
 - rust-lang#74370 (Reintroduce spotlight / "important traits" feature)
 - rust-lang#74390 (Fix typo in std::mem::transmute documentation)
 - rust-lang#74391 (BtreeMap: superficially refactor root access)
 - rust-lang#74392 (const generics triage)
 - rust-lang#74397 (Fix typo in the latest release note)
 - rust-lang#74406 (Set shell for github actions CI)

Failed merges:

r? @ghost
@bors bors merged commit a80559f into rust-lang:master Jul 16, 2020
@spastorino
Copy link
Member

Adding T-compiler label so we can go through this nomination during T-compiler meeting.

@spastorino spastorino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 22, 2020
@oli-obk oli-obk deleted the const_prop_ice branch July 23, 2020 11:17
@pnkfelix
Copy link
Member

discussed at weekly T-compiler triage meeting.

beta-accepted.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 23, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 7, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 7, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2020
@bors
Auto merge of rust-lang#75261 - Mark-Simulacrum:beta-next, r=Mark-Sim…
63ca028 
…ulacrum

[beta] backports

* Forbid non-derefable types explicitly in unsizing casts rust-lang#75136
* forbid `#[track_caller]` on main rust-lang#75130
* Fix #[track_caller] shims for trait objects. rust-lang#74784
* rustc_target: Add a target spec option for disabling `--eh-frame-hdr` rust-lang#74631
* Disable Azure Pipelines except for macOS rust-lang#74620
* Upload builds from GHA instead of Azure Pipelines rust-lang#74565
* Add the aarch64-apple-darwin target rust-lang#74541
* Use `ReEmpty(U0)` as the implicit region bound in typeck rust-lang#74509
* rustbuild: drop tool::should_install rust-lang#74457
* lint: use `transparent_newtype_field` to avoid ICE rust-lang#74340
* Don't panic if the lhs of a div by zero is not statically known rust-lang#74221
* improper_ctypes_definitions: allow `Box` rust-lang#74448
* typeck: check for infer before type impls trait rust-lang#73965
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

1.46.0-nightly panics on a particular proc macro invocation