improper_ctypes_definitions: allow Box
#74448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This commit stops linting against `Box` in `extern "C" fn`s for the `improper_ctypes_definitions` lint - boxes are documented to be FFI-safe. Signed-off-by: David Wood <david@davidtw.co>
davidtwco
force-pushed
the
improper-ctypes-definitions-boxes
branch
from
feddad1 to
95df802
Compare
|
Thanks for the quick fix! |
|
R=me when green |
|
@bors r+ (GHA is green) |
|
📌 Commit 95df802 has been approved by |
bors
added
S-waiting-on-bors
CryZe
reviewed
Jul 17, 2020
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 17, 2020
…ns-boxes, r=davidtwco improper_ctypes_definitions: allow `Box` Addresses rust-lang#72700 (comment). This PR stops linting against `Box` in `extern "C" fn`s for the `improper_ctypes_definitions` lint - boxes are documented to be FFI-safe. cc @alexcrichton @CryZe
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
…ns-boxes, r=davidtwco improper_ctypes_definitions: allow `Box` Addresses rust-lang#72700 (comment). This PR stops linting against `Box` in `extern "C" fn`s for the `improper_ctypes_definitions` lint - boxes are documented to be FFI-safe. cc @alexcrichton @CryZe
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
…ns-boxes, r=davidtwco improper_ctypes_definitions: allow `Box` Addresses rust-lang#72700 (comment). This PR stops linting against `Box` in `extern "C" fn`s for the `improper_ctypes_definitions` lint - boxes are documented to be FFI-safe. cc @alexcrichton @CryZe
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2020
…arth Rollup of 11 pull requests Successful merges: - rust-lang#72414 ( Add lazy initialization primitives to std) - rust-lang#74069 (Compare tagged/niche-filling layout and pick the best one) - rust-lang#74418 (ci: Set `shell: bash` as a default, remove duplicates) - rust-lang#74441 (bootstrap.py: patch RPATH on NixOS to handle the new zlib dependency.) - rust-lang#74444 (Add regression test for rust-lang#69414) - rust-lang#74448 (improper_ctypes_definitions: allow `Box`) - rust-lang#74449 (Test codegen of compare_exchange operations) - rust-lang#74450 (Fix `Safety` docs for `from_raw_parts_mut`) - rust-lang#74453 (Use intra-doc links in `str` and `BTreeSet`) - rust-lang#74457 (rustbuild: drop tool::should_install) - rust-lang#74464 (Use pathdiff crate) Failed merges: r? @ghost
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jul 20, 2020
The source of these warnings was fixed in rust-lang/rust#74448, yay!
|
Could I perhaps nominate this PR for beta inclusion as well? It looks like beta has this lint but doesn't have this fix. |
Mark-Simulacrum
added
the
beta-nominated
|
Adding |
spastorino
added
the
T-compiler
|
discussed at weekly T-compiler triage meeting. beta-accepted. |
pnkfelix
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2020
…ulacrum [beta] backports * Forbid non-derefable types explicitly in unsizing casts rust-lang#75136 * forbid `#[track_caller]` on main rust-lang#75130 * Fix #[track_caller] shims for trait objects. rust-lang#74784 * rustc_target: Add a target spec option for disabling `--eh-frame-hdr` rust-lang#74631 * Disable Azure Pipelines except for macOS rust-lang#74620 * Upload builds from GHA instead of Azure Pipelines rust-lang#74565 * Add the aarch64-apple-darwin target rust-lang#74541 * Use `ReEmpty(U0)` as the implicit region bound in typeck rust-lang#74509 * rustbuild: drop tool::should_install rust-lang#74457 * lint: use `transparent_newtype_field` to avoid ICE rust-lang#74340 * Don't panic if the lhs of a div by zero is not statically known rust-lang#74221 * improper_ctypes_definitions: allow `Box` rust-lang#74448 * typeck: check for infer before type impls trait rust-lang#73965
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #72700 (comment).
This PR stops linting against
Boxinextern "C" fns for theimproper_ctypes_definitionslint - boxes are documented to be FFI-safe.cc @alexcrichton @CryZe