Don't count variants/fields/consts/associated types in doc-coverage doc examples #75718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
You linked to the wrong issue, I think you meant #75714. |
|
I've been failing to reference the correct issue a lot lately. I think something is wrong with my copy/paste skill... |
jyn514
changed the title
jyn514
reviewed
Aug 19, 2020
GuillaumeGomez
force-pushed
the
coverage-ui-doc-examples-count
branch
from
d16ee60 to
d108bd5
Compare
|
Updated! |
|
@bors: r=jyn514 |
|
📌 Commit 10a880d has been approved by |
bors
added
S-waiting-on-bors
|
Ok, so with the nit fixed, we can r+! @bors: r=jyn514 |
|
📌 Commit adeedf5 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2020
Rollup of 12 pull requests Successful merges: - rust-lang#75705 (Move to intra-doc links for /library/core/src/intrinsics.rs) - rust-lang#75711 (Split `astconv.rs` into its own submodule) - rust-lang#75718 (Don't count variants/fields/consts/associated types in doc-coverage doc examples) - rust-lang#75725 (Use intra-doc-links in `alloc`) - rust-lang#75745 (Remove duplication in `fold_item`) - rust-lang#75753 (Another motivation for CFG: return-oriented programming) - rust-lang#75769 (Minor, remove double nesting of a test module) - rust-lang#75771 (Extend normalization in const-eval-query-stack test) - rust-lang#75781 (More inline asm register name fixups for LLVM) - rust-lang#75782 (Convert core/src/str/pattern.rs to Intra-doc links) - rust-lang#75787 (Use intra-doc-links in `core::ops::*`) - rust-lang#75788 (MIR call terminator represents diverging calls too) Failed merges: - rust-lang#75773 (Introduce expect snapshot testing library into rustc) r? @ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2020
…int-improvements, r=jyn514 Missing doc examples lint improvements Fixes rust-lang#75719. To be merged after rust-lang#75718 (only the two last commits are from this PR). Since you already reviewed rust-lang#75718, I'll set you as reviewer here as well. :) r? @jyn514
jyn514
added
the
T-rustdoc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75714.
I think I'll need to update the equivalent lint too. Creating an issue for that!
r? @jyn514