Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing doc examples lint improvements #75776

Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #75719.

To be merged after #75718 (only the two last commits are from this PR).

Since you already reviewed #75718, I'll set you as reviewer here as well. :)

r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2020
@GuillaumeGomez GuillaumeGomez force-pushed the missing-doc-examples-lint-improvements branch from c97cf99 to 40b3515 Compare August 21, 2020 16:07
@GuillaumeGomez GuillaumeGomez force-pushed the missing-doc-examples-lint-improvements branch from 40b3515 to 7a05f13 Compare August 21, 2020 16:08
@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

Looks good to me :) holding off on approving until #75718 is merged.

@ollie27 ollie27 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 22, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 22, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 22, 2020

📌 Commit 7a05f13 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2020
@bors
Copy link
Collaborator

bors commented Aug 22, 2020

⌛ Testing commit 7a05f13 with merge b1bb8aa...

@bors
Copy link
Collaborator

bors commented Aug 22, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing b1bb8aa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2020
@bors bors merged commit b1bb8aa into rust-lang:master Aug 22, 2020
@GuillaumeGomez GuillaumeGomez deleted the missing-doc-examples-lint-improvements branch August 22, 2020 09:26
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't count variants/fields/consts/associated types in missing_doc_code_examples lint
6 participants