impl Rc::new_cyclic
#75994
Merged
impl Rc::new_cyclic
#75994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
r? @KodrAus |
KodrAus
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Thanks for working on this @mental32!
This follows the same dance as Arc::new_cyclic, which carefully avoids creating references to uninitialized data. Would you like to pull in some of the comments from Arc::new_cyclic into this Rc::new_cyclic function too so visitors can follow what's going on?
|
@KodrAus I've mad the suggested changes, feel free to review again :) |
|
@bors r+ rollup |
|
📌 Commit 0f301e8 has been approved by |
bors
added
S-waiting-on-bors
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 5, 2020
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
This was referenced Sep 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75695 (Add a regression test for issue-72793) - rust-lang#75741 (Refactor byteorder to std in rustc_middle) - rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features) - rust-lang#75994 (`impl Rc::new_cyclic`) - rust-lang#76060 (Link vec doc to & reference) - rust-lang#76078 (Remove disambiguators from intra doc link text) - rust-lang#76082 (Fix intra-doc links on pub re-exports) - rust-lang#76254 (Fold length constant in Rvalue::Repeat) - rust-lang#76258 (x.py check checks tests/examples/benches) - rust-lang#76263 (inliner: Check for codegen fn attributes compatibility) - rust-lang#76285 (Move jointness censoring to proc_macro) Failed merges: r? @ghost
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #75861
r? @Dylan-DPC