Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

inliner: Check for codegen fn attributes compatibility #76263

Merged
merged 3 commits into from
Sep 5, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 2, 2020

  • Check for target features compatibility
  • Check for no_sanitize attribute compatibility

Fixes #76259.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2020
@tmiasko tmiasko force-pushed the inline-codegen-fn-attrs branch from 060a2dc to ae8018e Compare September 3, 2020 00:26
@tmiasko
Copy link
Contributor Author

tmiasko commented Sep 4, 2020

r? @ecstatic-morse

Copy link
Contributor

@ecstatic-morse ecstatic-morse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a question and a style nit.

@tmiasko tmiasko force-pushed the inline-codegen-fn-attrs branch from ae8018e to c23151b Compare September 4, 2020 18:46
@ecstatic-morse
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 4, 2020

📌 Commit c23151b has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 5, 2020
…ecstatic-morse

inliner: Check for codegen fn attributes compatibility

* Check for target features compatibility
* Check for no_sanitize attribute compatibility

Fixes rust-lang#76259.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#75695 (Add a regression test for issue-72793)
 - rust-lang#75741 (Refactor byteorder to std in rustc_middle)
 - rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features)
 - rust-lang#75994 (`impl Rc::new_cyclic`)
 - rust-lang#76060 (Link vec doc to & reference)
 - rust-lang#76078 (Remove disambiguators from intra doc link text)
 - rust-lang#76082 (Fix intra-doc links on pub re-exports)
 - rust-lang#76254 (Fold length constant in Rvalue::Repeat)
 - rust-lang#76258 (x.py check checks tests/examples/benches)
 - rust-lang#76263 (inliner: Check for codegen fn attributes compatibility)
 - rust-lang#76285 (Move jointness censoring to proc_macro)

Failed merges:

r? @ghost
@bors bors merged commit b4d3873 into rust-lang:master Sep 5, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 5, 2020
@tmiasko tmiasko deleted the inline-codegen-fn-attrs branch September 5, 2020 17:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM ERROR: Do not know how to split this operator's operand! with -Zmir-opt-level=2
6 participants