Skip to content

Move Wrapping<T> ui tests into library #76745

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2020
Merged

Move Wrapping<T> ui tests into library #76745

merged 3 commits into from
Oct 3, 2020

Conversation

workingjubilee
Copy link
Member

Part of #76268
r? @matklad

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2020
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 15, 2020
tesuji
tesuji reviewed Sep 16, 2020
View reviewed changes
@matklad
Copy link
Member

matklad commented Sep 24, 2020

r=me with this comment addressed

@bors delegate=workingjubilee

@bors
Copy link
Collaborator

bors commented Sep 24, 2020

✌️ @workingjubilee can now approve this pull request

@matklad
Copy link
Member

matklad commented Oct 2, 2020

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 2, 2020

📌 Commit 4e97396 has been approved by matklad

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 2, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2020
@bors
Auto merge of rust-lang#77470 - jonas-schievink:rollup-9a2hulp, r=jon…
6ebad43 
…as-schievink

Rollup of 8 pull requests

Successful merges:

 - rust-lang#75377 (Fix Debug implementations of some of the HashMap and BTreeMap iterator types)
 - rust-lang#76107 (Write manifest for MAJOR.MINOR channel to enable rustup convenience)
 - rust-lang#76745 (Move Wrapping<T> ui tests into library)
 - rust-lang#77182 (Add missing examples for Fd traits)
 - rust-lang#77251 (Bypass const_item_mutation if const's type has Drop impl)
 - rust-lang#77264 (Only use LOCAL_{STDOUT,STDERR} when set_{print/panic} is used. )
 - rust-lang#77421 (Revert "resolve: Avoid "self-confirming" import resolutions in one more case")
 - rust-lang#77452 (Permit ty::Bool in const generics for v0 mangling)

Failed merges:

r? `@ghost`
@bors bors merged commit 389f7cf into rust-lang:master Oct 3, 2020
@rustbot rustbot added this to the 1.48.0 milestone Oct 3, 2020
@workingjubilee workingjubilee deleted the move-wrapping-tests branch April 23, 2021 19:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tesuji tesuji tesuji left review comments

Assignees

@matklad matklad

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
7 participants
@workingjubilee @matklad @bors @tesuji @rust-highfive @jyn514 @rustbot