Skip to content

Add missing examples for Fd traits #77182

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 25, 2020

Not sure what happened here... This is a reopening of #77142

r? @Dylan-DPC

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 25, 2020

You linked the wrong PR again :P

///
/// fn main() -> std::io::Result<()> {
/// let mut f = File::open("foo.txt")?;
/// let raw_fd = f.as_raw_fd();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// let raw_fd = f.as_raw_fd();
/// let raw_fd: RawFd = f.as_raw_fd();

@GuillaumeGomez
Copy link
Member Author

Computers are my nemesis...

@jyn514 jyn514 added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 25, 2020
@Dylan-DPC-zz
Copy link

r? @jyn514

@rust-highfive rust-highfive assigned jyn514 and unassigned Dylan-DPC-zz Sep 25, 2020
@GuillaumeGomez GuillaumeGomez force-pushed the missing-examples-fd-traits branch from 4471d15 to a0485af Compare September 25, 2020 18:27
@GuillaumeGomez GuillaumeGomez force-pushed the missing-examples-fd-traits branch from a0485af to 980e1ff Compare September 25, 2020 19:21
@GuillaumeGomez
Copy link
Member Author

Updated!

@GuillaumeGomez
Copy link
Member Author

Updated! Let's how it works without a function to wrap. :)

@GuillaumeGomez
Copy link
Member Author

@bors: r=pickfire rollup

@bors
Copy link
Collaborator

bors commented Oct 2, 2020

📌 Commit d6b838b has been approved by pickfire

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2020
…as-schievink

Rollup of 8 pull requests

Successful merges:

 - rust-lang#75377 (Fix Debug implementations of some of the HashMap and BTreeMap iterator types)
 - rust-lang#76107 (Write manifest for MAJOR.MINOR channel to enable rustup convenience)
 - rust-lang#76745 (Move Wrapping<T> ui tests into library)
 - rust-lang#77182 (Add missing examples for Fd traits)
 - rust-lang#77251 (Bypass const_item_mutation if const's type has Drop impl)
 - rust-lang#77264 (Only use LOCAL_{STDOUT,STDERR} when set_{print/panic} is used. )
 - rust-lang#77421 (Revert "resolve: Avoid "self-confirming" import resolutions in one more case")
 - rust-lang#77452 (Permit ty::Bool in const generics for v0 mangling)

Failed merges:

r? `@ghost`
@bors bors merged commit ccc020a into rust-lang:master Oct 3, 2020
@rustbot rustbot added this to the 1.48.0 milestone Oct 3, 2020
@GuillaumeGomez GuillaumeGomez deleted the missing-examples-fd-traits branch October 3, 2020 11:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants