Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs #76876

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs #76876

merged 1 commit into from
Sep 20, 2020

Conversation

denisvasilik
Copy link
Contributor

Helps with #75080.

@rustbot modify labels: T-doc, A-intra-doc-links

@rustbot rustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Sep 18, 2020
@rust-highfive
Copy link
Collaborator

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2020
@denisvasilik
Copy link
Contributor Author

r? @jyn514

@denisvasilik
Copy link
Contributor Author

std/collections/struct.BTreeMap.html:265: broken link fragment #insert-and-complex-keyspointing tostd/index.html``

I'm on it.

jyn514
jyn514 reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with CI passing

@denisvasilik
Copy link
Contributor Author

I think self#insert-and-complex-keys should be the correct link, but there's again the problem with private items. So I'm going to revert that change.

814 |     /// [module-level documentation]: self#insert-and-complex-keys
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this item is private

@jyn514
Copy link
Member

jyn514 commented Sep 19, 2020

r=me with commits squashed, thanks for sticking with this! Let me know if you have trouble with git and I can help.

@denisvasilik
Copy link
Contributor Author

@bors r=jyn514

@bors
Copy link
Contributor

bors commented Sep 19, 2020

@denisvasilik: 🔑 Insufficient privileges: Not in reviewers

@denisvasilik
Copy link
Contributor Author

r? @jyn514

@jyn514
Copy link
Member

jyn514 commented Sep 20, 2020

@bors r+ rollup

Next time I'll @bors delegate denisvasilik, sorry about that

@bors
Copy link
Contributor

bors commented Sep 20, 2020

📌 Commit f9fa649 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 20, 2020
@RalfJung
Rollup merge of rust-lang#76876 - denisvasilik:intra-doc-links-alloc,…
f009ebe 
… r=jyn514

Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs

Helps with rust-lang#75080.

@rustbot modify labels: T-doc, A-intra-doc-links
This was referenced Sep 20, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2020
@bors
Auto merge of rust-lang#76975 - RalfJung:rollup-s2wiuqr, r=RalfJung
81e0270 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#76732 (Add docs for `BasicBlock`)
 - rust-lang#76832 (Let backends define custom targets)
 - rust-lang#76866 (Remove unused feature gates from library/ crates)
 - rust-lang#76875 (Move to intra-doc links in library/alloc/src/collections/binary_heap.rs)
 - rust-lang#76876 (Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs)
 - rust-lang#76877 (Move to intra-doc links in collections/vec_deque.rs and collections/vec_deque/drain.rs)
 - rust-lang#76878 (Move the version number to a plaintext file)
 - rust-lang#76883 (README.md: Remove prompts from code blocks)
 - rust-lang#76887 (Add missing examples on HashSet iter types)
 - rust-lang#76890 (use matches!() macro for simple if let conditions)
 - rust-lang#76891 (don't take `TyCtxt` by reference)
 - rust-lang#76910 (transmute: use diagnostic item)
 - rust-lang#76924 (Add tracking issue for feature(unix_socket_peek))
 - rust-lang#76926 (BTreeMap: code readability tweaks)
 - rust-lang#76940 (Don't allow implementing trait directly on type-alias-impl-trait)

Failed merges:

r? `@ghost`
@bors bors merged commit 3941201 into rust-lang:master Sep 20, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
6 participants
@denisvasilik @rust-highfive @jyn514 @bors @LukasKalbertodt @rustbot