use matches!() macro for simple if let conditions #76890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
lcnr
approved these changes
Sep 18, 2020
compiler/rustc_ast/src/ast.rs
Outdated
| @@ -2508,7 +2508,7 @@ pub enum VisibilityKind { | |||
|
|
|||
| impl VisibilityKind { | |||
| pub fn is_pub(&self) -> bool { | |||
| if let VisibilityKind::Public = *self { true } else { false } | |||
| matches!(*self, VisibilityKind::Public) | |||
There was a problem hiding this comment.
Suggested change
| matches!(*self, VisibilityKind::Public) | |
| matches!(self, VisibilityKind::Public) |
matthiaskrgr
force-pushed
the
matches_simpl
branch
from
2451ebc to
6d316b7
Compare
matthiaskrgr
force-pushed
the
matches_simpl
branch
from
6d316b7 to
40dddd3
Compare
|
Thanks @bors r+ rollup |
|
📌 Commit 40dddd3 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 20, 2020
use matches!() macro for simple if let conditions
This was referenced Sep 20, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#76732 (Add docs for `BasicBlock`) - rust-lang#76832 (Let backends define custom targets) - rust-lang#76866 (Remove unused feature gates from library/ crates) - rust-lang#76875 (Move to intra-doc links in library/alloc/src/collections/binary_heap.rs) - rust-lang#76876 (Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs) - rust-lang#76877 (Move to intra-doc links in collections/vec_deque.rs and collections/vec_deque/drain.rs) - rust-lang#76878 (Move the version number to a plaintext file) - rust-lang#76883 (README.md: Remove prompts from code blocks) - rust-lang#76887 (Add missing examples on HashSet iter types) - rust-lang#76890 (use matches!() macro for simple if let conditions) - rust-lang#76891 (don't take `TyCtxt` by reference) - rust-lang#76910 (transmute: use diagnostic item) - rust-lang#76924 (Add tracking issue for feature(unix_socket_peek)) - rust-lang#76926 (BTreeMap: code readability tweaks) - rust-lang#76940 (Don't allow implementing trait directly on type-alias-impl-trait) Failed merges: r? `@ghost`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.