Skip to content

[beta] try to work around type normalization regression #78845

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Nov 7, 2020

This just removes the offending lines that trigger #78139. I have doubts that this will actually solve the issue but it's simple enough to try.

This PR needs a crater run for the failing crate.

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2020
@Mark-Simulacrum
Copy link
Member

@bors try

I don't think a crater run here is necessary -- checking the one crate locally shouldn't be too hard -- but having artifacts for easier testing is nice :)

@bors
Copy link
Collaborator

bors commented Nov 7, 2020

⌛ Trying commit f20775a with merge 9898131620287f170f82e89c851e0d7fc8436424...

@the8472
Copy link
Member Author

the8472 commented Nov 7, 2020

I don't think a crater run here is necessary

It does have a command to run it for a single crate, is that still overkill?

@bors
Copy link
Collaborator

bors commented Nov 7, 2020

☀️ Try build successful - checks-actions
Build commit: 9898131620287f170f82e89c851e0d7fc8436424 (9898131620287f170f82e89c851e0d7fc8436424)

@the8472
Copy link
Member Author

the8472 commented Nov 7, 2020

Color me surprised, it worked.

[dilbert-feed]$ cargo +9898131620287f170f82e89c851e0d7fc8436424 build

[...]
Finished dev [unoptimized + debuginfo] target(s) in 15.71s


[dilbert-feed]$ cargo +beta build

[...]

error: internal compiler error: compiler/rustc_traits/src/normalize_erasing_regions.rs:37:32: could not fully normalize `<tokio::prelude::future::Either<tokio::prelude::future::Map<tokio::prelude::future::AndThen<tokio::prelude::future::AndThen<tokio::prelude::future::FutureResult<std::string::String, failure::Error>, std::result::Result<hyper::Uri, failure::Error>, [closure@src/main.rs:162:51: 162:96]>, tokio::prelude::future::Map<tokio::prelude::future::FromErr<tokio::prelude::future::AndThen<hyper::client::ResponseFuture, tokio::prelude::future::Map<tokio::prelude::stream::Concat2<hyper::Body>, [closure@src/main.rs:46:40: 46:62]>, fn(hyper::Response<hyper::Body>) -> impl hyper::rt::Future {concat_body}>, failure::Error>, [closure@src/main.rs:91:14: 95:10]>, [closure@src/main.rs:163:51: 163:92]>, [closure@src/main.rs:164:46: 167:42]>, tokio::prelude::future::FutureResult<ComicInfo, failure::Error>> as tokio::prelude::IntoFuture>::Future`

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

Can you also post an equivalent PR against master?

@bors
Copy link
Collaborator

bors commented Nov 7, 2020

📌 Commit f20775a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2020
@Dylan-DPC-zz
Copy link

@bors p=10

@bors
Copy link
Collaborator

bors commented Nov 8, 2020

⌛ Testing commit f20775a with merge 1219014...

@bors
Copy link
Collaborator

bors commented Nov 8, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1219014 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 8, 2020
@bors bors merged commit 1219014 into rust-lang:beta Nov 8, 2020
@rustbot rustbot added this to the 1.48.0 milestone Nov 8, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants