Skip to content

Add the "memcpy" doc alias to slice::copy_from_slice #79217

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Add the "memcpy" doc alias to slice::copy_from_slice #79217

merged 1 commit into from
Nov 20, 2020

Conversation

yoshuawuyts
Copy link
Member

RFC1419 describes slice::copy_from_slice as a "safe memcpy". This enables people searching for memcpy to find the slice::copy_from_slice method. Thanks!

Screenshots

This is currently the output when searching for "memcpy" -- copy_from_slice is safe, and should be part of this list.

Screenshot_2020-11-19 Results for memcpy - Rust

@rust-highfive
Copy link
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Thanks, I agree this is a good thing to call out. I had actually written some code just yesterday with copy_nonoverlapping after looking for memcpy...

@bors
Copy link
Collaborator

bors commented Nov 19, 2020

📌 Commit 53f969d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#79119 (Clarify availability of atomic operations)
 - rust-lang#79123 (Add u128 and i128 integer tests)
 - rust-lang#79177 (Test drop order for (destructuring) assignments)
 - rust-lang#79181 (rustdoc: add [src] links to methods on a trait's page)
 - rust-lang#79183 (Make compiletest testing use the local sysroot)
 - rust-lang#79185 (expand/resolve: Pre-requisites to "Turn `#[derive]` into a regular macro attribute")
 - rust-lang#79193 (Revert rust-lang#78969 "Normalize function type during validation")
 - rust-lang#79194 (Make as{_mut,}_slice on array::IntoIter public)
 - rust-lang#79204 (Add jyn514 email alias to mailmap)
 - rust-lang#79212 (Move `rustc_ty` -> `rustc_ty_utils`)
 - rust-lang#79217 (Add the "memcpy" doc alias to slice::copy_from_slice)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5adc00f into rust-lang:master Nov 20, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 20, 2020
@yoshuawuyts yoshuawuyts deleted the copy_from_slice-alias branch November 20, 2020 09:43
@GuillaumeGomez GuillaumeGomez added A-doc-alias Area: `#[doc(alias)]` T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 4, 2020
@jyn514 jyn514 added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-doc-alias Area: `#[doc(alias)]` A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants