Issue 8498 workaround #8518

catamorphism · 2013-08-14T23:57:56Z

This is a workaround for rust-lang#8498

@brson

Refactor `FormatArgsExpn` It now for each format argument `{..}` has: - The `Expr` it points to, and how it does so (named/named inline/numbered/implicit) - The parsed `FormatSpec` (format trait/fill/align/etc., the precision/width and any value they point to) - Many spans The caller no longer needs to pair up arguments to their value, or separately interpret the `specs` `Expr`s when it isn't `None` The gist is that it combines the result of [`rustc_parse_format::Parser`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_parse_format/struct.Parser.html) with the macro expansion itself This unfortunately makes the code a bit longer, however we need to use both as neither have all the information we're after. `rustc_parse_format` doesn't have the information to resolve named arguments to their values. The macro expansion doesn't contain whether the positions are implicit/numbered/named, or the spans for format arguments Wanted by rust-lang#9233 and rust-lang#8518 to be able to port the changes from rust-lang#9040 Also fixes rust-lang#8643, previously the format args seem to have been paired up with the wrong values somehow changelog: [`format_in_format_args`]: Fix false positive due to misattributed arguments r? `@flip1995` cc `@nyurik`

Migrate write.rs to a late pass changelog: Migrates write.rs from a pre expansion pass to a late pass changelog: [`positional_named_format_parameters`] is renamed in favour of the rustc lint `named_arguments_used_positionally` - Macros are now identified by diagnostic items, so will no longer lint user defined macros named, e.g. a custom `print!` - `print_literal`/`write_literal` no longer lint no longer lint literals that come from macro expansions, e.g. `env!("FOO")` - `print_with_newline`/`write_with_newline` no longer lint strings with any internal `\r` or `\n`s ~~A false negative, `print_literal`/`write_literal` don't lint format strings that produce `FormatSpec`s, e.g. ones containing pretty print/width/align specifiers~~ Suggestion changes: - ~~`print_literal`/`write_literal` no longer have suggestions, as the spans for the `{}`s were not easily obtainable~~ - `print_with_newline`/`write_with_newline` has a better suggestion for a sole literal newline, but no longer has suggestions for len > 1 strings that end in a literal newline - ~~`use_debug` spans are less precise, now point to the whole format string~~ The diff for write.rs is pretty unwieldy, other than for the `declare_clippy_lint!`s I think you'd be better off viewing it as a brand new file rather than looking at the diff, as it's mostly written from scratch cc rust-lang#6610, fixes rust-lang#5721, fixes rust-lang#7195, fixes rust-lang#8615

catamorphism added 2 commits August 14, 2013 16:52

std: Change ProcessOptions struct to have an option of a ~ vector

cf4694e

This is a workaround for rust-lang#8498

testsuite: Add xfailed test for rust-lang#8498

5be4408

catamorphism mentioned this pull request Aug 16, 2013

Specifying an env in run::ProcessOptions breaks finish_with_output #8028

Closed

bors added a commit that referenced this pull request Aug 16, 2013

auto merge of #8518 : catamorphism/rust/issue-8498-workaround, r=brson

92af0db

r? @brson

bors closed this Aug 16, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue 8498 workaround #8518

Issue 8498 workaround #8518

Uh oh!

catamorphism commented Aug 14, 2013

Uh oh!

Uh oh!

Issue 8498 workaround #8518

Issue 8498 workaround #8518

Uh oh!

Conversation

catamorphism commented Aug 14, 2013

Uh oh!

Uh oh!