Skip to content

Fix spelling and phrasing in 0.8 release notes #9349

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 21, 2013
Merged

Conversation

brson
Copy link
Contributor

@brson brson commented Sep 19, 2013

No description provided.

@kud1ing
Copy link

kud1ing commented Sep 20, 2013

Someone on Reddit noted a typo in line 95. It probably should read "le, gt and ge"?

@huonw huonw mentioned this pull request Sep 20, 2013
@brson
Copy link
Contributor Author

brson commented Sep 20, 2013

Fixed errors

bors added a commit that referenced this pull request Sep 21, 2013
@bors bors closed this Sep 21, 2013
@bors bors merged commit 5a0f7aa into rust-lang:master Sep 21, 2013
Jarcho pushed a commit to Jarcho/rust that referenced this pull request Aug 29, 2022
Refactor `FormatArgsExpn`

It now for each format argument `{..}` has:
- The `Expr` it points to, and how it does so (named/named inline/numbered/implicit)
- The parsed `FormatSpec` (format trait/fill/align/etc., the precision/width and any value they point to)
- Many spans

The caller no longer needs to pair up arguments to their value, or separately interpret the `specs` `Expr`s when it isn't `None`

The gist is that it combines the result of [`rustc_parse_format::Parser`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_parse_format/struct.Parser.html) with the macro expansion itself

This unfortunately makes the code a bit longer, however we need to use both as neither have all the information we're after. `rustc_parse_format` doesn't have the information to resolve named arguments to their values. The macro expansion doesn't contain whether the positions are implicit/numbered/named, or the spans for format arguments

Wanted by rust-lang#9233 and rust-lang#8518 to be able to port the changes from rust-lang#9040

Also fixes rust-lang#8643, previously the format args seem to have been paired up with the wrong values somehow

changelog: [`format_in_format_args`]: Fix false positive due to misattributed arguments

r? `@flip1995`
cc `@nyurik`
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants